Skip to content

Commit 11e84df

Browse files
aleDszjonatanklosko
authored andcommitted
Apply suggestions from #3164 comments
1 parent 32e89cf commit 11e84df

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

lib/livebook/zta/livebook_teams.ex

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,18 +169,18 @@ defmodule Livebook.ZTA.LivebookTeams do
169169
defp validate_access_token(name, conn, team, access_token) do
170170
node = get_session(conn, :livebook_teams_metadata_node)
171171

172-
entry =
173-
try do
174-
:erpc.call(node, :ets, :lookup_element, [name, access_token, 2, nil])
175-
catch
176-
_, _ -> nil
177-
end
178-
179172
case Teams.Requests.get_user_info(team, access_token) do
180173
{:ok, payload} ->
181174
{conn, build_metadata(team.id, payload)}
182175

183176
:econnrefused ->
177+
entry =
178+
try do
179+
:erpc.call(node, :ets, :lookup_element, [name, access_token, 2, nil])
180+
catch
181+
_, _ -> nil
182+
end
183+
184184
case {System.os_time(:second), entry} do
185185
{current_timestamp, {exp, metadata}} when current_timestamp <= exp ->
186186
{conn, metadata}
@@ -196,7 +196,12 @@ defmodule Livebook.ZTA.LivebookTeams do
196196
end
197197

198198
_otherwise ->
199-
entry && :erpc.call(node, :ets, :delete, [name, access_token])
199+
try do
200+
:erpc.call(node, :ets, :delete, [name, access_token])
201+
catch
202+
_, _ -> nil
203+
end
204+
200205
request_user_authentication(conn)
201206
end
202207
end

0 commit comments

Comments
 (0)