Skip to content

Remove unused fxa src/internal/auth.rs code#7396

Merged
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-wzwopnpvuyvp
Jun 5, 2026
Merged

Remove unused fxa src/internal/auth.rs code#7396
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-wzwopnpvuyvp

Conversation

@mhammond

@mhammond mhammond commented Jun 4, 2026

Copy link
Copy Markdown
Member

It contains code for things like manually deriving the sync key etc, which is now all done by the server.

The file existing makes it look like it is used, but it's not. It seems better not to confuse people grepping through the code.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

It contains code for things like manually deriving the sync key etc,
which is now all done by the server.

The file existing makes it look like it is used, but it's not.
It seems better not to confuse people grepping through the code.
@mhammond mhammond requested review from bendk and skhamis June 4, 2026 05:24

@skhamis skhamis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! LGTM!

@mhammond mhammond added this pull request to the merge queue Jun 5, 2026
Merged via the queue into mozilla:main with commit 6acc07d Jun 5, 2026
14 checks passed
@mhammond mhammond deleted the push-wzwopnpvuyvp branch June 5, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants