Skip to content

Commit ad44dc4

Browse files
authored
src: use context-free V8 message column getters
PR-URL: #62778 Refs: https://issues.chromium.org/issues/42210793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
1 parent 978a8c4 commit ad44dc4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/inspector_agent.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,7 @@ class NodeInspectorClient : public V8InspectorClient {
677677
ToInspectorString(isolate, message->Get())->string(),
678678
ToInspectorString(isolate, message->GetScriptResourceName())->string(),
679679
message->GetLineNumber(context).FromMaybe(0),
680-
message->GetStartColumn(context).FromMaybe(0),
680+
message->GetStartColumn(),
681681
client_->createStackTrace(stack_trace),
682682
script_id);
683683
}

src/node_errors.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate,
6565
// the source texts.
6666
Local<Value> script_resource_name = message->GetScriptResourceName();
6767
int linenum = message->GetLineNumber(context).FromJust();
68-
int columnum = message->GetStartColumn(context).FromJust();
68+
int columnum = message->GetStartColumn();
6969

7070
Local<Value> argv[] = {script_resource_name,
7171
v8::Int32::New(isolate, linenum),
@@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate,
148148
int script_start = (linenum - origin.LineOffset()) == 1
149149
? origin.ColumnOffset()
150150
: 0;
151-
int start = message->GetStartColumn(context).FromMaybe(0);
152-
int end = message->GetEndColumn(context).FromMaybe(0);
151+
int start = message->GetStartColumn();
152+
int end = message->GetEndColumn();
153153
if (start >= script_start) {
154154
CHECK_GE(end, start);
155155
start -= script_start;

0 commit comments

Comments
 (0)