Skip to content

Fix LimitRange minimum constraint descriptions#112866

Open
Amine-LG wants to merge 1 commit into
openshift:mainfrom
Amine-LG:fix-limitrange-min-constraints
Open

Fix LimitRange minimum constraint descriptions#112866
Amine-LG wants to merge 1 commit into
openshift:mainfrom
Amine-LG:fix-limitrange-min-constraints

Conversation

@Amine-LG

@Amine-LG Amine-LG commented Jun 5, 2026

Copy link
Copy Markdown

Summary

Fixes incorrect LimitRange wording in the compute resource quotas docs.

The current text says that when min is not set, a pod or container can consume more than the configured max value. That is incorrect: missing min means no minimum constraint is enforced; it does not disable max.

Also fixes a copy/paste error where a container memory entry is labeled max.memory but describes min.memory.

Verification

Tested on CRC with LimitRange objects that set max without min, and with min: 0.

oc create --dry-run=server confirmed that resources above max are still rejected.

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown

Hi @Amine-LG. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant