Skip to content

Commit ff664b0

Browse files
committed
fix
1 parent 013e86e commit ff664b0

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎src/Rules/PHPUnit/EmptyDataProviderRule.php‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ public function getNodeType(): string
4141

4242
public function processNode(Node $node, Scope $scope): array
4343
{
44+
// A generator yields its data sets one at a time, so whether it provides
45+
// any depends on control flow this rule cannot decide.
46+
if ($node->isGenerator()) {
47+
return [];
48+
}
49+
4450
$returnStatements = $node->getReturnStatements();
4551
if ($returnStatements === []) {
4652
return [];

‎tests/Rules/PHPUnit/EmptyDataProviderRuleTest.php‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ public function testRule(?int $version): void
6767
'Data provider method provideData() provides no data sets, which is an error in PHPUnit 10 and newer.',
6868
190,
6969
];
70-
$errors[] = [
71-
'Data provider method dataFileAsserts() provides no data sets, which is an error in PHPUnit 10 and newer.',
72-
310,
73-
];
7470
}
7571

7672
// DataProviderHelper only reads the attribute when the detected major version supports it.

0 commit comments

Comments
 (0)