Reduce reliance on Timex and use native time API where feasible (#5712)

* Replace usages of `Timex.to_unix` with native API

* Wrap call to `Timex.is_valid_timezone?`

* Wrap calls to `Timex.today(tz)`

* Replace `Timex.today()` with `Date.utc_today()`

* Replace `Timex.now()` with `DateTime.utc_now()`

* Replace `Timex.compare` with `Date.compare`

* Wrap `Timex.diff` calls

* Replace `Timex.Timezone.convert` with `DateTime.shift_zone!`

* Wrap `Timex.parse!`

* Replace `Timex.to_date` with native API calls

* Replace `Timex.beginning|end_of...` with native API calls for Date

* Wrap `Timex.beginning|end_of...` for DateTimes and Dates for years

* Replace `Timex.format(!)` with native API calls

* Replace `Timex.to_naive_datetime` with native API calls

* Wrap time humanizing routines using Timex

* Remove unnecessary `use Timex` instances

* Replace `Timex.shift` with native API calls

* Make `QueryParser.parse_date` handle gaps and ambiguities gracefully

* Replace `Timex.now(tz)` with `DateTime.now!(tz)`

* Use a more suitable Date function for comparison (h/t @aerosol)

Author: zoldar

lib/plausible/auth/totp.ex

@@ -336,7 +336,9 @@ defmodule Plausible.Auth.TOTP do
       |> Repo.one()
 
     if datetime do
-      Timex.to_unix(datetime)
+      datetime
+      |> DateTime.from_naive!("Etc/UTC")
+      |> DateTime.to_unix()
     end
   end
 

lib/plausible/billing/subscriptions.ex

@@ -27,7 +27,7 @@ defmodule Plausible.Billing.Subscriptions do
 
   def expired?(%Subscription{next_bill_date: next_bill_date} = subscription) do
     deleted? = Subscription.Status.deleted?(subscription)
-    expired? = Timex.compare(next_bill_date, Date.utc_today()) < 0
+    expired? = Date.before?(next_bill_date, Date.utc_today())
 
     deleted? && expired?
   end

lib/plausible/data_migration/populate_event_session_columns.ex

@@ -150,8 +150,6 @@ defmodule Plausible.DataMigration.PopulateEventSessionColumns do
   end
 
   defp format_duration(seconds) do
-    seconds
-    |> Timex.Duration.from_seconds()
-    |> Timex.format_duration(Timex.Format.Duration.Formatters.Humanized)
+    Plausible.Times.humanize_seconds(seconds)
   end
 end

lib/plausible/exports.ex

@@ -154,7 +154,7 @@ defmodule Plausible.Exports do
             ["expiry-date=", expiry_date, ", rule-id=", _rule_id] =
               String.split(x_amz_expiration, "\"", trim: true)
 
-            Timex.parse!(expiry_date, "{RFC1123}")
+            Plausible.Times.parse!(expiry_date, "{RFC1123}")
           end
 
         %{

lib/plausible/google/api.ex

@@ -3,8 +3,6 @@ defmodule Plausible.Google.API do
   API to Google services.
   """
 
-  use Timex
-
   alias Plausible.Google.HTTP
   alias Plausible.Google.SearchConsole
   alias Plausible.Stats.Query

lib/plausible/google/ga4/http.ex

@@ -269,7 +269,7 @@ defmodule Plausible.Google.GA4.HTTP do
         date =
           case report["rows"] do
             [%{"dimensionValues" => [%{"value" => date_str}]}] ->
-              Timex.parse!(date_str, "%Y%m%d", :strftime) |> NaiveDateTime.to_date()
+              Plausible.Times.parse!(date_str, "%Y%m%d", :strftime) |> NaiveDateTime.to_date()
 
             _ ->
               nil

lib/plausible/imported/google_analytics4.ex

@@ -337,7 +337,7 @@ defmodule Plausible.Imported.GoogleAnalytics4 do
 
   defp get_date(%{dimensions: %{"date" => date}}) do
     date
-    |> Timex.parse!("%Y%m%d", :strftime)
+    |> Plausible.Times.parse!("%Y%m%d", :strftime)
     |> NaiveDateTime.to_date()
   end
 

lib/plausible/site.ex

@@ -222,7 +222,7 @@ defmodule Plausible.Site do
   defp validate_timezone(changeset) do
     tz = get_field(changeset, :timezone)
 
-    if Timex.is_valid_timezone?(tz) do
+    if Plausible.Timezones.valid?(tz) do
       changeset
     else
       add_error(changeset, :timezone, "is invalid")

lib/plausible/stats/filters/query_parser.ex

@@ -197,8 +197,12 @@ defmodule Plausible.Stats.Filters.QueryParser do
   end
 
   defp parse_date(site, date_string, _date, _now) when is_binary(date_string) do
-    case Date.from_iso8601(date_string) do
-      {:ok, date} -> {:ok, date, DateTime.new!(date, ~T[00:00:00], site.timezone)}
+    with {:ok, date} <- Date.from_iso8601(date_string),
+         {:ok, datetime} <- DateTime.new(date, ~T[00:00:00], site.timezone) do
+      {:ok, date, datetime}
+    else
+      {:gap, just_before, _just_after} -> just_before
+      {:ambiguous, first_datetime, _second_datetime} -> first_datetime
       _ -> {:error, "Invalid date '#{date_string}'."}
     end
   end
@@ -231,8 +235,8 @@ defmodule Plausible.Stats.Filters.QueryParser do
   end
 
   defp parse_time_range(site, "year", date, _now) do
-    last = date |> Timex.end_of_year()
-    first = last |> Timex.beginning_of_year()
+    last = date |> Plausible.Times.end_of_year()
+    first = last |> Plausible.Times.beginning_of_year()
     {:ok, DateTimeRange.new!(first, last, site.timezone)}
   end
 

lib/plausible/stats/interval.ex

@@ -42,7 +42,7 @@ defmodule Plausible.Stats.Interval do
   """
   def default_for_date_range(%DateTimeRange{first: first, last: last}) do
     cond do
-      Timex.diff(last, first, :months) > 0 ->
+      Plausible.Times.diff(last, first, :month) > 0 ->
         "month"
 
       DateTime.diff(last, first, :day) > 0 ->
@@ -75,15 +75,15 @@ defmodule Plausible.Stats.Interval do
     table =
       with %Date{} = from <- Keyword.get(opts, :from),
            %Date{} = to <- Keyword.get(opts, :to),
-           true <- abs(Timex.diff(from, to, :months)) > 12 do
+           true <- abs(Plausible.Times.diff(from, to, :month)) > 12 do
         Map.replace(@valid_by_period, "custom", ["week", "month"])
       else
         _ ->
           @valid_by_period
       end
 
     with %Date{} = stats_start <- Plausible.Sites.stats_start_date(site),
-         true <- abs(Timex.diff(Date.utc_today(), stats_start, :months)) > 12 do
+         true <- abs(Plausible.Times.diff(Date.utc_today(), stats_start, :month)) > 12 do
       Map.replace(table, "all", ["week", "month"])
     else
       _ ->