pytest documents Config.getvalue() as deprecated in favor of Config.getoption() (soft deprecation, no warning is emitted — see https://github.com/pytest-dev/pytest/blob/68308aa288e00ff84880572ed9b3590f6cd7d470/src/_pytest/config/__init__.py#L2096).
The plugin currently calls getvalue in several places in src/pytest_rerunfailures.py (e.g. for reruns, force_reruns, reruns_mode, reruns_delay, reruns_delay_backoff_factor, collectonly). They should all be switched to getoption in one consistent cleanup.
Note: getoption's default parameter only applies when the option does not exist at all, not when its value is None, so this is a cosmetic change with no behavior difference for our registered options.
Follow-up to the review discussion in #343.
— Comment created by Claude
pytest documents
Config.getvalue()as deprecated in favor ofConfig.getoption()(soft deprecation, no warning is emitted — see https://github.com/pytest-dev/pytest/blob/68308aa288e00ff84880572ed9b3590f6cd7d470/src/_pytest/config/__init__.py#L2096).The plugin currently calls
getvaluein several places insrc/pytest_rerunfailures.py(e.g. forreruns,force_reruns,reruns_mode,reruns_delay,reruns_delay_backoff_factor,collectonly). They should all be switched togetoptionin one consistent cleanup.Note:
getoption'sdefaultparameter only applies when the option does not exist at all, not when its value isNone, so this is a cosmetic change with no behavior difference for our registered options.Follow-up to the review discussion in #343.
— Comment created by Claude