Skip to content

Commit c2a762e

Browse files
authored
[mypyc] Generate lowered IR for abs() on native ints (#22499)
Follow-up to #22367, as suggested in #22367 (comment). This generates lowered IR for native integer `abs()` with a generic primitive op, `int_abs`, that gets lowered via `@lower_primitive_op` in `mypyc/lower/int_ops.py` (kind of like `vec_get_item_unsafe_op`). Before, mypyc converted the value to a tagged int, called `CPyTagged_Absolute` and converted the result back. `abs()` of the minimum value of a signed type, such as `abs(i8(-128))`, now overflows like `-x` instead of raising `ValueError`. `mypyc/doc/int_operations.rst` says operations between native integer types don't check for overflow, and there's no run test for `-x` overflow either, so I didn't add one for `abs()`. The new lowering tests fail on master.
1 parent 809ffcc commit c2a762e

4 files changed

Lines changed: 73 additions & 2 deletions

File tree

‎mypyc/irbuild/specialize.py‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@
147147
from mypyc.primitives.float_ops import isinstance_float
148148
from mypyc.primitives.generic_ops import generic_setattr, setup_object
149149
from mypyc.primitives.int_ops import (
150+
int_abs_op,
150151
int_to_big_endian_op,
151152
int_to_bytes_op,
152153
int_to_little_endian_op,
@@ -415,6 +416,16 @@ def translate_builtins_with_unary_dunder(
415416
return None
416417

417418

419+
@specialize_function("builtins.abs")
420+
def translate_abs(builder: IRBuilder, expr: CallExpr, callee: RefExpr) -> Value | None:
421+
if len(expr.args) == 1 and expr.arg_kinds == [ARG_POS]:
422+
arg_type = builder.node_type(expr.args[0])
423+
if is_fixed_width_rtype(arg_type):
424+
arg = builder.accept(expr.args[0])
425+
return builder.builder.primitive_op(int_abs_op, [arg], expr.line, type_args=[arg_type])
426+
return None
427+
428+
418429
@specialize_function("builtins.len")
419430
def translate_len(builder: IRBuilder, expr: CallExpr, callee: RefExpr) -> Value | None:
420431
if len(expr.args) == 1 and expr.arg_kinds == [ARG_POS]:

‎mypyc/lower/int_ops.py‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
from typing import NamedTuple
66

7-
from mypyc.ir.ops import Assign, BasicBlock, Branch, ComparisonOp, Register, Value
8-
from mypyc.ir.rtypes import bool_rprimitive, is_short_int_rprimitive
7+
from mypyc.ir.ops import Assign, BasicBlock, Branch, ComparisonOp, Integer, IntOp, Register, Value
8+
from mypyc.ir.rtypes import bool_rprimitive, is_fixed_width_rtype, is_short_int_rprimitive
99
from mypyc.irbuild.ll_builder import LowLevelIRBuilder
1010
from mypyc.lower.registry import lower_primitive_op
1111
from mypyc.primitives.int_ops import int_equal_, int_less_than_
@@ -111,3 +111,22 @@ def lower_int_gt(builder: LowLevelIRBuilder, args: list[Value], line: int) -> Va
111111
@lower_primitive_op("int_ge")
112112
def lower_int_ge(builder: LowLevelIRBuilder, args: list[Value], line: int) -> Value:
113113
return compare_tagged(builder, args[0], args[1], ">=", line)
114+
115+
116+
@lower_primitive_op("int_abs")
117+
def lower_int_abs(builder: LowLevelIRBuilder, args: list[Value], line: int) -> Value:
118+
x = args[0]
119+
typ = x.type
120+
assert is_fixed_width_rtype(typ)
121+
if not typ.is_signed:
122+
return x
123+
result = Register(typ)
124+
builder.add(Assign(result, x, line))
125+
neg, out = BasicBlock(), BasicBlock()
126+
is_neg = builder.comparison_op(x, Integer(0, typ), ComparisonOp.SLT, line)
127+
builder.add(Branch(is_neg, neg, out, Branch.BOOL))
128+
builder.activate_block(neg)
129+
negated = builder.int_op(typ, Integer(0, typ), x, IntOp.SUB, line)
130+
builder.add(Assign(result, negated, line))
131+
builder.goto_and_activate(out)
132+
return result

‎mypyc/primitives/int_ops.py‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
)
2020
from mypyc.ir.rtypes import (
2121
RType,
22+
RTypeVar,
2223
bit_rprimitive,
2324
bool_rprimitive,
2425
bytes_rprimitive,
@@ -214,6 +215,15 @@ def int_unary_op(name: str, c_function_name: str) -> PrimitiveDescription:
214215
error_kind=ERR_NEVER,
215216
)
216217

218+
# abs(x) for fixed-width x, lowered to inline IR
219+
int_abs_op = custom_primitive_op(
220+
name="int_abs",
221+
arg_types=[RTypeVar(0)],
222+
return_type=RTypeVar(0),
223+
error_kind=ERR_NEVER,
224+
type_params=[RTypeVar(0)],
225+
)
226+
217227

218228
# Primitives related to integer comparison operations:
219229

‎mypyc/test-data/lowering-int.test‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,3 +380,34 @@ L5:
380380
L6:
381381
r11 = <error> :: None
382382
return r11
383+
384+
[case testLowerI64Abs]
385+
from mypy_extensions import i64
386+
387+
def f(x: i64) -> i64:
388+
return abs(x)
389+
[out]
390+
def f(x):
391+
x, r0 :: i64
392+
r1 :: bit
393+
r2 :: i64
394+
L0:
395+
r0 = x
396+
r1 = x < 0 :: signed
397+
if r1 goto L1 else goto L2 :: bool
398+
L1:
399+
r2 = 0 - x
400+
r0 = r2
401+
L2:
402+
return r0
403+
404+
[case testLowerU8Abs]
405+
from mypy_extensions import u8
406+
407+
def f(x: u8) -> u8:
408+
return abs(x)
409+
[out]
410+
def f(x):
411+
x :: u8
412+
L0:
413+
return x

0 commit comments

Comments
 (0)