Repository navigation
Conversation
Two beta links on the proposal review session page open the new My review and Team review areas. Each area is a Django admin view that renders an Astro page, with tabs for its screens and a link to the other area. Each view checks the same access as the old page it replaces. The screens are placeholders for now.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Adds beta entry links and Astro-rendered app shells for the new CFP review pages (My review and Team review areas, four placeholder screens) as admin views on
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude/pycon-cfp-review-requirements-c4e96a #4867 +/- ##
============================================================================
Coverage 92.61% 92.61%
============================================================================
Files 360 360
Lines 10958 10958
Branches 953 953
============================================================================
Hits 10149 10149
Misses 684 684
Partials 125 125 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4864. Part 1 of 3 of the new CFP review pages (beta).
What
Two beta links on the proposal review session page open the new review pages, next to the old review and shortlist links:
Each area also links to the other. Every screen has its own URL (
/admin/reviews/reviewsession/<id>/beta/<screen>/), so links can be shared./beta/redirects to Focus Mode.ReviewSession.user_can_review, as on the old review page and shortlist. Team review also passescan_decide(reviews.decision_reviewsession) to the page for later.No database changes.
Testing
pytest reviews/tests: 93 passed, on top of Let reviewers abstain on proposals and grants #4864.can_decidefor a reviewer and a decider, refusal for a reviewer of another conference, 404 for grant sessions and unknown screens, and the links appearing only on proposal sessions.