Skip to content

Add beta entry and app shell for the new CFP review pages - #4867

Draft
EdAbati wants to merge 1 commit into
claude/pycon-cfp-review-requirements-c4e96afrom
claude/cfp-review-beta-shell
Draft

EdAbati wants to merge 1 commit into
claude/pycon-cfp-review-requirements-c4e96afrom
claude/cfp-review-beta-shell

Conversation

@EdAbati

@EdAbati EdAbati commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #4864. Part 1 of 3 of the new CFP review pages (beta).

What

Two beta links on the proposal review session page open the new review pages, next to the old review and shortlist links:

  • My review (beta) opens Focus Mode. Its tabs are Focus Mode and All proposals.
  • Team review (beta) opens the Shortlist. Its tabs are Shortlist and Speakers.

Each area also links to the other. Every screen has its own URL (/admin/reviews/reviewsession/<id>/beta/<screen>/), so links can be shared. /beta/ redirects to Focus Mode.

  • Each area is a Django admin view that renders an Astro page, like the schedule builder.
  • Each view checks the same access as the old page it replaces: ReviewSession.user_can_review, as on the old review page and shortlist. Team review also passes can_decide (reviews.decision_reviewsession) to the page for later.
  • Grant review sessions get no links, and their beta URLs return 404, as does an unknown screen.
  • All four screens are placeholders here. Focus Mode is filled in by the third PR in the stack.

No database changes.

Testing

  • pytest reviews/tests: 93 passed, on top of Let reviewers abstain on proposals and grants #4864.
  • New tests cover each screen's template and links, can_decide for a reviewer and a decider, refusal for a reviewer of another conference, 404 for grant sessions and unknown screens, and the links appearing only on proposal sessions.
  • Checked by hand: both links open, the tabs switch screens, and the breadcrumbs lead back to the review session.

Two beta links on the proposal review session page open the new
My review and Team review areas. Each area is a Django admin view that
renders an Astro page, with tabs for its screens and a link to the
other area. Each view checks the same access as the old page it
replaces. The screens are placeholders for now.
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pycon Ready Ready Preview Nov 16, 2026 9:41pm UTC

@claude

claude Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Adds beta entry links and Astro-rendered app shells for the new CFP review pages (My review and Team review areas, four placeholder screens) as admin views on ReviewSessionAdmin.

  • backend/reviews/admin.py: the imports are out of order. django.utils.text sits before django.utils.safestring, so ruff check (isort) will likely fail. Run ruff check --fix.
  • _review_beta_my_review and _review_beta_team_review repeat the same user_can_review check and context build. Do the check once in review_beta_view, then add can_decide and pick the template by area. That keeps the permission check in one place as more screens arrive.
  • BETA_AREAS, BETA_SCREENS and BETA_SCREEN_AREAS are module-level constants. BETA_SCREEN_AREAS and the template choice both encode the same screen-to-area mapping, so a new screen needs edits in several places. Consider deriving the template from the area in the BETA_AREAS mapping.
  • review_beta_start_view redirects without checking that the session exists or that the user has access. Access is enforced on the target page, so this is harmless. It still sends a bad ID through a redirect before returning 404.
  • The Astro roots (my-review-root.tsx, team-review-root.tsx) take untyped props, which are implicit any under strict TS. Type them.

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.61%. Comparing base (10bb524) to head (fd76930).

Additional details and impacted files
@@                             Coverage Diff                              @@
##           claude/pycon-cfp-review-requirements-c4e96a    #4867   +/-   ##
============================================================================
  Coverage                                        92.61%   92.61%           
============================================================================
  Files                                              360      360           
  Lines                                            10958    10958           
  Branches                                           953      953           
============================================================================
  Hits                                             10149    10149           
  Misses                                             684      684           
  Partials                                           125      125           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
Preview — fd769303 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant