Skip to content

Commit 78c7607

Browse files
authored
fix keybinds, caution icon and dependency row appearance, add libs (#2291)
1 parent 2c79fa2 commit 78c7607

File tree

5 files changed

+70
-12
lines changed

5 files changed

+70
-12
lines changed

components/Icons/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1107,6 +1107,7 @@ export function CautionBlockquote({ width = 24, height = 24, style }: IconProps)
11071107
x2="128"
11081108
y2="80"
11091109
fill="none"
1110+
stroke="currentColor"
11101111
strokeLinecap="round"
11111112
strokeLinejoin="round"
11121113
strokeWidth="24"
@@ -1118,7 +1119,7 @@ export function CautionBlockquote({ width = 24, height = 24, style }: IconProps)
11181119
strokeMiterlimit="10"
11191120
strokeWidth="24"
11201121
/>
1121-
<Circle cx="128" cy="172" r="24" fill="currentColor" />
1122+
<Circle cx="128" cy="172" r="16" fill="currentColor" />
11221123
</Svg>
11231124
);
11241125
}

components/InputKeyHint.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,19 @@ type Props = {
88
}[];
99
};
1010

11-
export const focusHintLabel = tw`font-light text-palette-gray4`;
12-
export const focusHintKey = tw`min-w-6 rounded-[3px] bg-palette-gray5 px-1 py-[3px] text-center tracking-[0.75px] text-tertiary dark:bg-powder`;
13-
1411
export default function InputKeyHint({ content }: Props) {
1512
return content.map(entry => {
1613
if ('key' in entry) {
1714
return (
18-
<Label key={`key-${entry.key}`} style={focusHintKey}>
15+
<Label
16+
key={`key-${entry.key}`}
17+
style={tw`min-w-6 rounded-[3px] bg-palette-gray5 px-1 py-[3px] text-center tracking-[0.75px] text-tertiary dark:bg-powder dark:text-secondary`}>
1918
{entry.key}
2019
</Label>
2120
);
2221
} else if ('label' in entry) {
2322
return (
24-
<Label key={`key-${entry.label}`} style={focusHintLabel}>
23+
<Label key={`key-${entry.label}`} style={tw`font-light text-palette-gray4`}>
2524
{entry.label}
2625
</Label>
2726
);

components/Package/DependencyRow.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,14 @@ type Props = {
1818

1919
export default function DependencyRow({ name, data, packageVersion }: Props) {
2020
const { isSmallScreen } = useLayout();
21+
2122
const isDataString = typeof data === 'string';
23+
const versionString = isDataString ? data : data.version;
24+
const hasLongVersion = versionString.length > 18;
2225
const versionLabel = getVersionLabel(
23-
isDataString ? data : data.version,
26+
versionString,
2427
typeof packageVersion === 'string' ? packageVersion : undefined
2528
);
26-
const hasLongVersion = typeof versionLabel !== 'string' || versionLabel.length > 18;
2729

2830
return (
2931
<View

react-native-libraries.json

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20069,5 +20069,56 @@
2006920069
"npmPkg": "react-zlib-js",
2007020070
"ios": true,
2007120071
"android": true
20072+
},
20073+
{
20074+
"githubUrl": "https://github.com/hyochan/react-native-audio-recorder-player",
20075+
"ios": true,
20076+
"android": true,
20077+
"web": true,
20078+
"alternatives": ["react-native-nitro-sound"]
20079+
},
20080+
{
20081+
"githubUrl": "https://github.com/expo/expo-asset-utils",
20082+
"ios": true,
20083+
"android": true,
20084+
"web": true,
20085+
"alternatives": ["expo-asset", "expo-file-system"]
20086+
},
20087+
{
20088+
"githubUrl": "https://github.com/acostalima/react-native-polyfill-globals",
20089+
"ios": true,
20090+
"android": true
20091+
},
20092+
{
20093+
"githubUrl": "https://github.com/ide/react-native-button",
20094+
"ios": true,
20095+
"android": true
20096+
},
20097+
{
20098+
"githubUrl": "https://github.com/glepur/react-native-swipe-gestures",
20099+
"ios": true,
20100+
"android": true
20101+
},
20102+
{
20103+
"githubUrl": "https://github.com/naeemur/react-native-wheel-color-picker",
20104+
"images": ["https://naeemur.github.io/asset-bucket/rn-wheel-color-picker.gif"],
20105+
"ios": true,
20106+
"android": true,
20107+
"web": true
20108+
},
20109+
{
20110+
"githubUrl": "https://github.com/nandorojo/sf-symbols-typescript",
20111+
"ios": true,
20112+
"macos": true,
20113+
"tvos": true,
20114+
"visionos": true
20115+
},
20116+
{
20117+
"githubUrl": "https://github.com/expo/expo/tree/main/packages/@expo/metro-runtime",
20118+
"npmPkg": "@expo/metro-runtime",
20119+
"ios": true,
20120+
"macos": true,
20121+
"tvos": true,
20122+
"visionos": true
2007220123
}
2007320124
]

styles/styles.css

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,15 @@ select {
522522
display: block;
523523
}
524524

525+
&.note,
526+
&.tip,
527+
&.important,
528+
&.warning,
529+
&.caution {
530+
padding-block-start: 0.5rem;
531+
padding-block-end: 0.5rem;
532+
}
533+
525534
&.note {
526535
border-left-color: #4493f8;
527536

@@ -703,10 +712,6 @@ select {
703712
}
704713
}
705714

706-
td:empty {
707-
display: none;
708-
}
709-
710715
th {
711716
background-color: var(--table-header-background);
712717
}

0 commit comments

Comments
 (0)