Undo featureflag default true & promote to canary instead, enable for Meta overrides#57372
Closed
zeyap wants to merge 1 commit into
Closed
Undo featureflag default true & promote to canary instead, enable for Meta overrides#57372zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
… Meta overrides Summary: ## Changelog: [Internal] - Undo featureflag default true & promote to canary instead, enable for Meta overrides We need more discussion about testing in canary before release. Since 0.87 cut is coming soon, let's not enable the flag for 0.87 just yet Reviewed By: javache Differential Revision: D110053624
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110053624. |
|
This pull request has been merged in b364490. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] - Undo featureflag default true & promote to canary instead, enable for Meta overrides
We need more discussion about testing in canary before release. Since 0.87 cut is coming soon, let's not enable the flag for 0.87 just yet
Reviewed By: javache
Differential Revision: D110053624