Skip to content

Commit e3c3c22

Browse files
committed
fix(cdn): use enum for ListDistributions SortBy
1 parent c39e521 commit e3c3c22

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

docs/stackit_beta_cdn_distribution_list.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ stackit beta cdn distribution list [flags]
2525
```
2626
-- int Limit the output to the first n elements
2727
-h, --help Help for "stackit beta cdn distribution list"
28-
--sort-by string Sort entries by a specific field, (one of: [id, createdAt, updatedAt, originUrl, status, originUrlRelated]) (default "createdAt")
28+
--sort-by string Sort entries by a specific field, (one of: [id, updatedAt, createdAt, originUrl, status, originUrlRelated]) (default "createdAt")
2929
```
3030

3131
### Options inherited from parent commands

internal/cmd/beta/cdn/distribution/list/list.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323

2424
type inputModel struct {
2525
*globalflags.GlobalFlagModel
26-
SortBy string
26+
SortBy cdn.ListDistributionsSortByParameter
2727
Limit *int32
2828
}
2929

@@ -34,9 +34,9 @@ const (
3434

3535
var sortByFlag = flags.StringEnumFlag(
3636
"sort-by",
37-
[]string{"id", "createdAt", "updatedAt", "originUrl", "status", "originUrlRelated"},
37+
cdn.AllowedListDistributionsSortByParameterEnumValues,
3838
"Sort entries by a specific field,",
39-
flags.StringEnumDefaultValue("createdAt"),
39+
flags.StringEnumDefaultValue(cdn.LISTDISTRIBUTIONSSORTBYPARAMETER_CREATED_AT),
4040
)
4141

4242
func NewCmd(params *types.CmdParams) *cobra.Command {

internal/cmd/beta/cdn/distribution/list/list_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414
"github.com/google/uuid"
1515
sdkConfig "github.com/stackitcloud/stackit-sdk-go/core/config"
1616
cdn "github.com/stackitcloud/stackit-sdk-go/services/cdn/v1api"
17-
"github.com/stackitcloud/stackit-sdk-go/services/cdn/v1api/wait"
1817

1918
"github.com/stackitcloud/stackit-cli/internal/pkg/testparams"
2019

@@ -32,7 +31,7 @@ var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
3231
const (
3332
testNextPageID = "next-page-id-123"
3433
testID = "dist-1"
35-
testStatus = wait.DISTRIBUTIONSTATUS_ACTIVE
34+
testStatus = cdn.DISTRIBUTIONSTATUS_ACTIVE
3635
)
3736

3837
func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
@@ -62,7 +61,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
6261
func fixtureRequest(mods ...func(request cdn.ApiListDistributionsRequest) cdn.ApiListDistributionsRequest) cdn.ApiListDistributionsRequest {
6362
request := testClient.DefaultAPI.ListDistributions(testCtx, testProjectId)
6463
request = request.PageSize(100)
65-
request = request.SortBy("createdAt")
64+
request = request.SortBy(cdn.LISTDISTRIBUTIONSSORTBYPARAMETER_CREATED_AT)
6665
for _, mod := range mods {
6766
request = mod(request)
6867
}
@@ -196,7 +195,7 @@ func TestBuildRequest(t *testing.T) {
196195
model.SortBy = "updatedAt"
197196
}),
198197
expected: fixtureRequest(func(req cdn.ApiListDistributionsRequest) cdn.ApiListDistributionsRequest {
199-
return req.SortBy("updatedAt")
198+
return req.SortBy(cdn.LISTDISTRIBUTIONSSORTBYPARAMETER_UPDATED_AT)
200199
}),
201200
},
202201
{

0 commit comments

Comments
 (0)