Skip to content

Improve pagination call #364

Description

@mysiki

Hey, can you improve pagination management ? I use this api for manage many users and many groups, but each call consume "+1" api call ... For each call, you iterate until result are null. So last call is unless, it's just for test than you don't have other page.

It's possible to use 2 methods :
1 - Use the header return, gitlab give some paging information on header, and the next page if exist .. So you can check this header value pour stop iteration .
2 - You have variable "item per page", so just count call return entry Vs item per page. If return count are < item per page, you don't need to call the next page

Hope you can take time on it. :)

Activity

  1. timols commented on Oct 26, 2019

    @timols
    Owner

    Hi @mysiki, I'd be happy to review/merge a PR but unfortunately don't have the bandwidth at the moment to contribute this change myself

  2. mysiki commented on Oct 27, 2019

    @mysiki
    Author

    I will be very happy to do this, but i didn't have thé skill for doing that...i will try,maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions