|
| 1 | +import { describe, expect, it } from "vitest"; |
| 2 | +import { parseDeployBaseImages, resolveDeployBaseImages } from "~/v3/deployBaseImages.server"; |
| 3 | + |
| 4 | +const digestA = `sha256:${"a".repeat(64)}`; |
| 5 | +const digestB = `sha256:${"b".repeat(64)}`; |
| 6 | +const digestC = `sha256:${"c".repeat(64)}`; |
| 7 | + |
| 8 | +describe("parseDeployBaseImages", () => { |
| 9 | + it("returns an empty map for undefined and empty values", () => { |
| 10 | + const empty = { images: {}, errors: [] }; |
| 11 | + expect(parseDeployBaseImages(undefined, "DEPLOY_BASE_IMAGES")).toEqual(empty); |
| 12 | + expect(parseDeployBaseImages("", "DEPLOY_BASE_IMAGES")).toEqual(empty); |
| 13 | + expect(parseDeployBaseImages(" , ,", "DEPLOY_BASE_IMAGES")).toEqual(empty); |
| 14 | + }); |
| 15 | + |
| 16 | + it("parses multiple entries and trims whitespace", () => { |
| 17 | + expect( |
| 18 | + parseDeployBaseImages( |
| 19 | + ` node-24 = acme/node-fips:24@${digestA} , bun=acme/bun:1@${digestB},`, |
| 20 | + "DEPLOY_BASE_IMAGES" |
| 21 | + ) |
| 22 | + ).toEqual({ |
| 23 | + images: { |
| 24 | + "node-24": `acme/node-fips:24@${digestA}`, |
| 25 | + bun: `acme/bun:1@${digestB}`, |
| 26 | + }, |
| 27 | + errors: [], |
| 28 | + }); |
| 29 | + }); |
| 30 | + |
| 31 | + it("accepts a registry with a port and a tag before the digest", () => { |
| 32 | + const image = `registry.example.com:5000/ns/img:tag@${digestA}`; |
| 33 | + expect(parseDeployBaseImages(`node-24=${image}`, "DEPLOY_BASE_IMAGES")).toEqual({ |
| 34 | + images: { "node-24": image }, |
| 35 | + errors: [], |
| 36 | + }); |
| 37 | + }); |
| 38 | + |
| 39 | + it.each([ |
| 40 | + ["missing =", "garbage"], |
| 41 | + ["unknown runtime", `node-23=acme/node:23@${digestA}`], |
| 42 | + ["node alias", `node=acme/node:24@${digestA}`], |
| 43 | + ["empty image", "node-24="], |
| 44 | + ["missing digest", "node-24=acme/node:24"], |
| 45 | + ["flag before image", `node-24=--platform=linux/arm64 acme/node@${digestA}`], |
| 46 | + ["bare digest", `node-24=@${digestA}`], |
| 47 | + ["newline in image", `node-24=acme/node\nx@${digestA}`], |
| 48 | + ["duplicate runtime", `node-24=acme/a@${digestA},node-24=acme/b@${digestB}`], |
| 49 | + ])("reports an error naming the env var and segment: %s", (_name, value) => { |
| 50 | + const segments = value.split(","); |
| 51 | + const offending = segments[segments.length - 1]!.trim(); |
| 52 | + |
| 53 | + const { images, errors } = parseDeployBaseImages( |
| 54 | + `node-22=acme/ok@${digestC},${value}`, |
| 55 | + "DEPLOY_BUILD_BASE_IMAGES" |
| 56 | + ); |
| 57 | + |
| 58 | + expect(images["node-22"]).toBe(`acme/ok@${digestC}`); |
| 59 | + expect(errors).toHaveLength(1); |
| 60 | + expect(errors[0]).toContain("DEPLOY_BUILD_BASE_IMAGES"); |
| 61 | + expect(errors[0]).toContain(offending); |
| 62 | + }); |
| 63 | + |
| 64 | + it("explains that node is an alias", () => { |
| 65 | + const { errors } = parseDeployBaseImages(`node=acme/node@${digestA}`, "DEPLOY_BASE_IMAGES"); |
| 66 | + expect(errors[0]).toContain('runtime "node" is an alias; use the concrete runtime'); |
| 67 | + }); |
| 68 | + |
| 69 | + it("reports every bad segment", () => { |
| 70 | + const { errors } = parseDeployBaseImages( |
| 71 | + `garbage,node-23=acme/node@${digestA},bun=acme/bun`, |
| 72 | + "DEPLOY_BASE_IMAGES" |
| 73 | + ); |
| 74 | + expect(errors).toHaveLength(3); |
| 75 | + expect(errors[0]).toContain("garbage"); |
| 76 | + expect(errors[1]).toContain("node-23"); |
| 77 | + expect(errors[2]).toContain("bun=acme/bun"); |
| 78 | + }); |
| 79 | +}); |
| 80 | + |
| 81 | +describe("resolveDeployBaseImages", () => { |
| 82 | + const base = { "node-26": `acme/node-fips:26@${digestA}` } as const; |
| 83 | + const buildBase = { "node-26": `acme/node:26-dev@${digestB}` } as const; |
| 84 | + |
| 85 | + it("returns undefined for a missing or unknown runtime", () => { |
| 86 | + expect(resolveDeployBaseImages("node-23", { base, buildBase })).toBeUndefined(); |
| 87 | + expect(resolveDeployBaseImages(null, { base, buildBase })).toBeUndefined(); |
| 88 | + expect(resolveDeployBaseImages(undefined, { base, buildBase })).toBeUndefined(); |
| 89 | + }); |
| 90 | + |
| 91 | + it("returns undefined when the runtime has no entries", () => { |
| 92 | + expect(resolveDeployBaseImages("bun", { base, buildBase })).toBeUndefined(); |
| 93 | + expect(resolveDeployBaseImages("node-26", { base: {}, buildBase: {} })).toBeUndefined(); |
| 94 | + }); |
| 95 | + |
| 96 | + it("returns both images", () => { |
| 97 | + expect(resolveDeployBaseImages("node-26", { base, buildBase })).toEqual({ |
| 98 | + base: base["node-26"], |
| 99 | + buildBase: buildBase["node-26"], |
| 100 | + }); |
| 101 | + }); |
| 102 | + |
| 103 | + it("returns only the base image", () => { |
| 104 | + expect(resolveDeployBaseImages("node-26", { base, buildBase: {} })).toEqual({ |
| 105 | + base: base["node-26"], |
| 106 | + }); |
| 107 | + }); |
| 108 | + |
| 109 | + it("returns only the build base image", () => { |
| 110 | + expect(resolveDeployBaseImages("node-26", { base: {}, buildBase })).toEqual({ |
| 111 | + buildBase: buildBase["node-26"], |
| 112 | + }); |
| 113 | + }); |
| 114 | +}); |
0 commit comments