bootstrap the db without using sqlite connection

If we try to bootstrap the db after a connection is opened, then it is
incorrect, as it could create a local .db file and a successful sync
would replace this file

Author: avinassh

libsql/src/local/database.rs

@@ -465,8 +465,8 @@ impl Database {
     /// Sync WAL frames to remote.
     pub async fn sync_offline(&self) -> Result<crate::database::Replicated> {
         let mut sync_ctx = self.sync_ctx.as_ref().unwrap().lock().await;
+        crate::sync::bootstrap_db(&mut sync_ctx).await?;
         let conn = self.connect()?;
-
         crate::sync::sync_offline(&mut sync_ctx, &conn).await
     }
 

libsql/src/sync.rs

@@ -680,6 +680,28 @@ async fn atomic_write<P: AsRef<Path>>(path: P, data: &[u8]) -> Result<()> {
     Ok(())
 }
 
+/// bootstrap_db brings the .db file from remote, if required. If the .db file already exists, then
+/// it does nothing. Calling this function multiple times is safe.
+pub async fn bootstrap_db(sync_ctx: &mut SyncContext) -> Result<()> {
+    // todo: we are checking with the remote server only during initialisation. ideally,
+    // we need to do this when we notice a large gap in generations, when bootstrapping is cheaper
+    // than pulling each frame
+    if !sync_ctx.initial_server_sync {
+        // sync is being called first time. so we will call remote, get the generation information
+        // if we are lagging behind, then we will call the export API and get to the latest
+        // generation directly.
+        let info = sync_ctx.get_remote_info().await?;
+        sync_ctx
+            .sync_db_if_needed(info.current_generation)
+            .await?;
+        // when sync_ctx is initialised, we set durable_generation to 0. however, once
+        // sync_db is called, it should be > 0.
+        assert!(sync_ctx.durable_generation > 0, "generation should be > 0");
+        sync_ctx.initial_server_sync = true;
+    }
+    Ok(())
+}
+
 /// Sync WAL frames to remote.
 pub async fn sync_offline(
     sync_ctx: &mut SyncContext,
@@ -701,22 +723,6 @@ pub async fn sync_offline(
             Err(e) => Err(e),
         }
     } else {
-        // todo: we are checking with the remote server only during initialisation. ideally,
-        // we should check everytime we try to sync with the remote server. However, we need to close
-        // all the ongoing connections since we replace `.db` file and remove the `.db-wal` file
-        if !sync_ctx.initial_server_sync {
-            // sync is being called first time. so we will call remote, get the generation information
-            // if we are lagging behind, then we will call the export API and get to the latest
-            // generation directly.
-            let info = sync_ctx.get_remote_info().await?;
-            sync_ctx
-                .sync_db_if_needed(info.current_generation)
-                .await?;
-            // when sync_ctx is initialised, we set durable_generation to 0. however, once
-            // sync_db is called, it should be > 0.
-            assert!(sync_ctx.durable_generation > 0, "generation should be > 0");
-            sync_ctx.initial_server_sync = true;
-        }
         try_pull(sync_ctx, conn).await
     }
     .or_else(|err| {