From 11a28593d6ef743bd788195eaa88689dfeddd081 Mon Sep 17 00:00:00 2001 From: Mohamad Jaara <9083456+MohamadJaara@users.noreply.github.com> Date: Wed, 26 Aug 2026 13:26:12 +0200 Subject: [PATCH] fix: disable pending message retry on app open --- .../kotlin/com/wire/android/GlobalObserversManager.kt | 4 ---- .../kotlin/com/wire/android/GlobalObserversManagerTest.kt | 8 ++++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/app/src/main/kotlin/com/wire/android/GlobalObserversManager.kt b/app/src/main/kotlin/com/wire/android/GlobalObserversManager.kt index 554c0af41c1..18681431e22 100644 --- a/app/src/main/kotlin/com/wire/android/GlobalObserversManager.kt +++ b/app/src/main/kotlin/com/wire/android/GlobalObserversManager.kt @@ -85,10 +85,6 @@ class GlobalObserversManager @Inject constructor( } scope.handleLogouts() scope.handleDeleteEphemeralMessageEndDate() - - if (kaliumConfigs.pendingMessages) { - scope.retryPendingMessagesOnAppOpen() - } } private suspend fun setUpNotifications() { diff --git a/app/src/test/kotlin/com/wire/android/GlobalObserversManagerTest.kt b/app/src/test/kotlin/com/wire/android/GlobalObserversManagerTest.kt index 109ab60b733..8612c219646 100644 --- a/app/src/test/kotlin/com/wire/android/GlobalObserversManagerTest.kt +++ b/app/src/test/kotlin/com/wire/android/GlobalObserversManagerTest.kt @@ -171,7 +171,7 @@ class GlobalObserversManagerTest { } @Test - fun `given app visible and valid session, when app opens, then retry sending pending messages`() { + fun `given app visible and valid session, when app opens, then do not retry sending pending messages`() { val (arrangement, manager) = Arrangement() .withCurrentSession(CurrentSessionResult.Success(AccountInfo.Valid(TestUser.SELF_USER.id))) .withAppVisibleFlow(true) @@ -179,7 +179,7 @@ class GlobalObserversManagerTest { manager.observe() - coVerify(exactly = 1) { arrangement.sendPendingMessagesAfterForegroundSync(TestUser.SELF_USER.id) } + coVerify(exactly = 0) { arrangement.sendPendingMessagesAfterForegroundSync(any()) } } @Test @@ -257,7 +257,7 @@ class GlobalObserversManagerTest { } @Test - fun `given valid session when app becomes visible then retry sending pending messages`() { + fun `given valid session when app becomes visible then do not retry sending pending messages`() { val appVisibleFlow = MutableStateFlow(false) val (arrangement, manager) = Arrangement() .withCurrentSession(CurrentSessionResult.Success(AccountInfo.Valid(TestUser.SELF_USER.id))) @@ -269,7 +269,7 @@ class GlobalObserversManagerTest { appVisibleFlow.value = true - coVerify(exactly = 1) { arrangement.sendPendingMessagesAfterForegroundSync(TestUser.SELF_USER.id) } + coVerify(exactly = 0) { arrangement.sendPendingMessagesAfterForegroundSync(any()) } } @Test