Skip to content

feat: store and verify genesis protocol configuration - #2590

Merged
kkovaacs merged 4 commits into
nextfrom
krisztian/store-protocol-config
Sep 11, 2026
Merged

feat: store and verify genesis protocol configuration#2590
kkovaacs merged 4 commits into
nextfrom
krisztian/store-protocol-config

Conversation

@kkovaacs

@kkovaacs kkovaacs commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Include the full protocol configuration in genesis.dat and verify its commitment against the genesis header.
  • Store the configuration atomically with genesis state and expose lookup by commitment.

Changelog

[[entry]]
scope       = "general"
impact      = "breaking"
description = "Persist and verify the genesis protocol configuration. Genesis files must now include the full configuration; existing deployments require a new genesis artifact and a fresh bootstrap."

Stack created with GitHub Stacks CLI • Give Feedback 💬

Mirko-von-Leipzig
Mirko-von-Leipzig approved these changes Sep 8, 2026
View reviewed changes

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/external/src/network-operator/bootstrap-and-genesis.md Outdated
Comment thread docs/external/src/full-node/bootstrap.md
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch from 83567cd to f5631e6 Compare September 10, 2026 08:58
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch 2 times, most recently from 55f356b to c35ca81 Compare September 10, 2026 09:21
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch from c35ca81 to dab5efe Compare September 10, 2026 09:54
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch from dab5efe to 0759330 Compare September 11, 2026 08:52
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch from 0759330 to 75ad18f Compare September 11, 2026 09:06
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch from 75ad18f to 0759330 Compare September 11, 2026 10:45
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch 2 times, most recently from 10b97b3 to 9e40eb9 Compare September 11, 2026 11:29
Base automatically changed from krisztian/miden-objects-migration to next September 11, 2026 11:35
@kkovaacs
kkovaacs force-pushed the krisztian/store-protocol-config branch from 9e40eb9 to b905724 Compare September 11, 2026 11:35
@kkovaacs
kkovaacs merged commit 4243794 into next Sep 11, 2026
32 checks passed
@kkovaacs
kkovaacs deleted the krisztian/store-protocol-config branch September 11, 2026 11:43
bobbinth
bobbinth reviewed Sep 11, 2026
View reviewed changes
Comment thread crates/store/src/db/migrations/006_protocol_configs.sql
Comment on lines +1 to +4
CREATE TABLE protocol_configs (
commitment BLOB NOT NULL PRIMARY KEY CHECK (length(commitment) = 32),
protocol_config BLOB NOT NULL
) WITHOUT ROWID;

@bobbinth bobbinth Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also want to store the block height at which a given config became "effective"? i.e., the genesis config would be effective as of block 0 etc.

@Mirko-von-Leipzig Mirko-von-Leipzig Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed here: #2596 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbinth bobbinth bobbinth left review comments
@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkovaacs @bobbinth @Mirko-von-Leipzig