Skip to content

Default wait_for_slices to wait for all available slices. #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 1, 2026
+7 −2
Merged

Default wait_for_slices to wait for all available slices. #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pathwaysutils/elastic/elastic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def get_active_slice_indices(


def wait_for_slices(
slice_count: int,
slice_count: int | None = None,
poll_interval: float | int = 10,
timeout: float | int | None = None,
slice_to_devices: Mapping[int, Sequence[jax.Device]] | None = None,
Expand All @@ -180,7 +180,8 @@ def wait_for_slices(
"""Waits until after at least `slice_count` slices become active.

Args:
slice_count: The number of slices to wait for.
slice_count: The number of slices to wait for. If None, defaults to the
total number of slices.
poll_interval: The minimum number of seconds to wait between availability
checks. If the check takes longer than this, the next check will start
immediately after the current check completes. Defaults to 10 seconds.
Expand All @@ -201,6 +202,10 @@ def wait_for_slices(
_logger.debug("slice_to_devices is None. Getting from jax.devices().")
slice_to_devices = get_slice_to_devices(jax.devices())

if slice_count is None:
_logger.debug("slice_count is None. Using len(slice_to_devices).")
slice_count = len(slice_to_devices)

_logger.info(
"Waiting for %s slices. Poll interval: %s, Timeout: %s",
slice_count,
Expand Down
Loading