fix: SG-44910: defer HDPI resize workaround until after window is shown - #1392
Merged
bernie-laberge merged 1 commit intoAug 25, 2026
Conversation
The Qt6 HDPI resize trick was scheduled from the RvDocument constructor, which could race with QML-backed UI startup and crash in QQmlData on Linux. Run it from showEvent instead, and only when HDPI scaling is active. Signed-off-by: Bernard Laberge <bernard.laberge@autodesk.com>
bernie-laberge
marked this pull request as ready for review
August 25, 2026 15:30
bernie-laberge
requested review from
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
August 25, 2026 15:30
cedrik-fuoco-adsk
approved these changes
Aug 25, 2026
eloisebrosseau
approved these changes
Aug 25, 2026
bernie-laberge
merged commit Aug 25, 2026
09930b8
into
AcademySoftwareFoundation:main
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SG-44910: defer HDPI resize workaround until after window is shown
Linked issues
NA
Describe the reason for the change.
QQmlData::isSignalConnectedtriggered fromRvDocumentconstructor HDPI resizeSummarize your change.
showEvent, matching the original intent (Feature/Qt6 - Fix hdpi issue that magically fixes itself when resizing the main window #709) that it run after the view is showndevicePixelRatio() > 1.0Describe what you have tested and on which operating system.
Successfully tested on Rocky Linux 9
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.