Repository navigation
Add unit tests for retrieveArticleData - #94
Merged
AlexJSully merged 2 commits intoOct 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The browser-loaded minified script remains unchanged, leaving the new HTTP error handling unavailable to users.
1 open issue
What changed in this PR
Adds coverage for article metadata retrieval and improves HTTP failure handling.
Changes:
- Tests successful retrieval, network errors, HTTP errors, and invalid JSON.
- Returns the retrieval promise and rejects non-OK responses.
- Improves test cleanup and disables automatic page initialization.
| File | Description |
|---|---|
| src/scripts/index.test.js | Adds retrieval tests and test isolation. |
| src/scripts/index.js | Returns the fetch promise and checks HTTP status. |
Review effort: Balanced
AlexJSully
deleted the
87-testing-improve-test-coverage-for-fetch-operations
branch
October 19, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.