Skip to content

[PWGCF] Fixes in femto framework#16661

Merged
ariedel-cern merged 7 commits into
AliceO2Group:masterfrom
ariedel-cern:master
Jun 15, 2026
Merged

[PWGCF] Fixes in femto framework#16661
ariedel-cern merged 7 commits into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

@ariedel-cern ariedel-cern commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Fixing typos and other small issues throughout the framework.

@github-actions github-actions Bot added the pwgcf label Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [PWGCF] Fixes in femto framework [PWGCF] Fixes in femto framework Jun 15, 2026
@alibuild alibuild mentioned this pull request Jun 15, 2026
Merged
@vkucera

vkucera commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Seems like the include formatting resets the file permissions. I will have a look into it.

@ariedel-cern

ariedel-cern commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @vkucera , thanks for having a look and the fast response.

@vkucera

vkucera commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Hi @vkucera , thanks for having a look and the fast response.

In the meantime, please merge the formatting PR to pass the check. Sorry for the inconvenience.

@ariedel-cern
Merge pull request #19 from alibuild/alibot-cleanup-16661
9c9fa1c 
[PWGCF] Please consider the following formatting changes to AliceO2Group#16661
@ariedel-cern ariedel-cern marked this pull request as ready for review June 15, 2026 10:59
@ariedel-cern ariedel-cern enabled auto-merge (squash) June 15, 2026 10:59
alibuild
alibuild approved these changes Jun 15, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern ariedel-cern merged commit 1278c39 into AliceO2Group:master Jun 15, 2026
13 of 14 checks passed
@alibuild

alibuild commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 9c9fa1c at 2026-06-15 14:12:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9c9fa1c at 2026-06-15 14:17:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ariedel-cern @vkucera @alibuild