Skip to content

[Common,PWGJE] Adding embedding for jets - #18088

Merged
nzardosh merged 1 commit into
AliceO2Group:masterfrom
nzardosh:embeddingFinal
Oct 7, 2026
Merged

[Common,PWGJE] Adding embedding for jets#18088
nzardosh merged 1 commit into
AliceO2Group:masterfrom
nzardosh:embeddingFinal

Conversation

@nzardosh

@nzardosh nzardosh commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds the ability to do embedding to the jet framework

@nzardosh
nzardosh marked this pull request as draft September 29, 2026 08:21
@github-actions github-actions Bot changed the title Adding embedding for jets [Common,PWGJE] Adding embedding for jets Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 295 warnings, 🔕 0 disabled

@nzardosh

nzardosh commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Need this PR AliceO2Group/AliceO2#15836 to be committed to O2 first

@alibuild alibuild mentioned this pull request Sep 29, 2026
Closed
@nzardosh nzardosh mentioned this pull request Oct 2, 2026
Merged
@nzardosh
nzardosh marked this pull request as ready for review October 6, 2026 12:22
@nzardosh
nzardosh enabled auto-merge (squash) October 6, 2026 12:22
@alibuild

alibuild commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 4bda01b at 2026-10-06 16:07:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:97: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:157: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::McParticlesFrom = o2::aod::McParticles_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:160: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: invalid template-id
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: missing template argument list after 'o2::soa::Join'; template placeholder not permitted in parameter
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:2128:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected identifier before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected ',' or '...' before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:76:52: error: 'mcdCollisions' was not declared in this scope; did you mean 'collisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:89: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::BCsFrom = o2::aod::BCs_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:93: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:80:29: error: 'bcs' was not declared in this scope; did you mean 'bc'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:70: error: 'McCollisionsFrom' is not a member of 'o2::aod'; did you mean 'JMcCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:108: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:110: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:112: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(EmbeddingQATask*&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:275:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:62: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:173:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:163:64: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:19: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:55: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:57: error: expected unqualified-id before '>' token
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:201:70: error: 'TracksExtraFrom' is not a member of 'o2::aod'; did you mean 'UDTracksExtraFrom'?
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4bda01b at 2026-10-06 16:25:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:97: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:157: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::McParticlesFrom = o2::aod::McParticles_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:160: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: invalid template-id
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: missing template argument list after 'o2::soa::Join'; template placeholder not permitted in parameter
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:2128:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected identifier before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected ',' or '...' before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:76:52: error: 'mcdCollisions' was not declared in this scope; did you mean 'collisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:89: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::BCsFrom = o2::aod::BCs_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:93: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:80:29: error: 'bcs' was not declared in this scope; did you mean 'bc'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:70: error: 'McCollisionsFrom' is not a member of 'o2::aod'; did you mean 'JMcCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:108: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:110: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:112: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(EmbeddingQATask*&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:275:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:62: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:173:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:163:64: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:19: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:55: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:57: error: expected unqualified-id before '>' token
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:201:70: error: 'TracksExtraFrom' is not a member of 'o2::aod'; did you mean 'UDTracksExtraFrom'?
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 4bda01b at 2026-10-06 16:51:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:97: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:157: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::McParticlesFrom = o2::aod::McParticles_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:160: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: invalid template-id
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: missing template argument list after 'o2::soa::Join'; template placeholder not permitted in parameter
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:2128:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected identifier before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected ',' or '...' before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:76:52: error: 'mcdCollisions' was not declared in this scope; did you mean 'collisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:89: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::BCsFrom = o2::aod::BCs_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:93: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:80:29: error: 'bcs' was not declared in this scope; did you mean 'bc'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:70: error: 'McCollisionsFrom' is not a member of 'o2::aod'; did you mean 'JMcCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:108: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:110: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:112: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(EmbeddingQATask*&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:275:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:62: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:173:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:163:64: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:19: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:55: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:57: error: expected unqualified-id before '>' token
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:201:70: error: 'TracksExtraFrom' is not a member of 'o2::aod'; did you mean 'UDTracksExtraFrom'?
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 094027e at 2026-10-07 12:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 23 errors and 54 warnings.'
Found 23 errors and 54 warnings.
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/034871ba977c940ba947555af7ec7b58ebd2d81e/O2Physics-code-check/errors.txt
Common/DataModel/Multiplicity.h:220:16: error: no header providing "o2::aod::is_origin_hash" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:16:1: error: included header JetDQUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:18:1: error: included header JetV0Utilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:26:1: error: included header ReducedInfoTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:27:1: error: included header DerivedTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:29:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:36:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:58: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:821:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:17:1: error: included header FastJetUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:22:1: error: included header TrackSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:23:1: error: included header TrackSelectionDefaults.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:24:1: error: included header EventSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:25:1: error: included header TrackSelectionTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:40:103: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:60:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:60:21: error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:63:8: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:66:28: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:74:92: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:76:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:122:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 54 -gt 0 ]]
++ cat /sw/BUILD/034871ba977c940ba947555af7ec7b58ebd2d81e/O2Physics-code-check/warnings.txt
PWGJE/Core/JetDerivedDataUtilities.h:77:7: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Core/JetDerivedDataUtilities.h:308:7: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Core/JetDerivedDataUtilities.h:508:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetDerivedDataUtilities.h:650:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetDerivedDataUtilities.h:674:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetDerivedDataUtilities.h:743:10: warning: variable 'end' is not initialized [cppcoreguidelines-init-variables]
PWGJE/Core/JetFindingUtilities.h:44:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Core/JetFindingUtilities.h:269:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetFindingUtilities.h:270:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:351:82: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetFindingUtilities.h:353:7: warning: do not use 'else' after 'continue' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:412:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/JetFinders/jetFinderHFHFBar.h:48:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/JetFinders/jetFinderHFHFBar.h:51:8: warning: constructor does not initialize these fields: pdgDatabase [cppcoreguidelines-pro-type-member-init]
PWGJE/JetFinders/jetFinderHFHFBar.h:188:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/JetFinders/jetFinderHFHFBar.h:189:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/JetFinders/jetFinderHF.h:48:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 094027e at 2026-10-06 18:47:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:97: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:157: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::McParticlesFrom = o2::aod::McParticles_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:160: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: invalid template-id
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: missing template argument list after 'o2::soa::Join'; template placeholder not permitted in parameter
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:2128:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected identifier before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected ',' or '...' before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:76:52: error: 'mcdCollisions' was not declared in this scope; did you mean 'collisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:89: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::BCsFrom = o2::aod::BCs_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:93: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:80:29: error: 'bcs' was not declared in this scope; did you mean 'bc'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:70: error: 'McCollisionsFrom' is not a member of 'o2::aod'; did you mean 'JMcCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:108: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:110: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:112: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(EmbeddingQATask*&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:275:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:62: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:173:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:163:64: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:19: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:55: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:57: error: expected unqualified-id before '>' token
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:201:70: error: 'TracksExtraFrom' is not a member of 'o2::aod'; did you mean 'UDTracksExtraFrom'?
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 094027e at 2026-10-06 18:47:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:97: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:157: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::McParticlesFrom = o2::aod::McParticles_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:160: error: expected identifier before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: invalid template-id
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:302: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:338: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:287: error: missing template argument list after 'o2::soa::Join'; template placeholder not permitted in parameter
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:2128:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected identifier before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:74:392: error: expected ',' or '...' before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:122:3: error: no matching function for call to 'ProcessConfigurable(void (EmbeddingQATask::*)(...), const char [22], bool, const char [9])'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:76:52: error: 'mcdCollisions' was not declared in this scope; did you mean 'collisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:89: error: template constraint failure for 'template<class O>  requires  is_origin_hash<O> using o2::aod::BCsFrom = o2::aod::BCs_001From<O>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:78:93: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:80:29: error: 'bcs' was not declared in this scope; did you mean 'bc'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:70: error: 'McCollisionsFrom' is not a member of 'o2::aod'; did you mean 'JMcCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:108: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:110: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:83:112: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:98:30: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/embeddingQA.cxx:105:30: error: 'end' was not declared in this scope
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/StructToTuple.h:61:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(EmbeddingQATask*&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:275:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:62: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/DataModel/JetReducedData.h:173:26: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:163:64: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:19: error: 'CollisionsFrom' is not a member of 'o2::aod'; did you mean 'JCollisionsFrom'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:55: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:199:57: error: expected unqualified-id before '>' token
/sw/slc9_x86-64/O2/daily-20261006-0000-local1/include/Framework/AnalysisDataModel.h:502:1: error: template constraint failure for 'template<class L, class D, class O, class ... Ts>  requires (is_aod_hash<L>) && (is_aod_hash<D>) && (is_origin_hash<O>) class o2::soa::Table'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:201:70: error: 'TracksExtraFrom' is not a member of 'o2::aod'; did you mean 'UDTracksExtraFrom'?
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for db161c6 at 2026-10-07 13:18:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 23 errors and 54 warnings.'
Found 23 errors and 54 warnings.
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/09189678f90c0b3c35af5cfc80e39d4ad3741be2/O2Physics-code-check/errors.txt
Common/DataModel/Multiplicity.h:220:16: error: no header providing "o2::aod::is_origin_hash" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:16:1: error: included header JetDQUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:18:1: error: included header JetV0Utilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:26:1: error: included header ReducedInfoTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:27:1: error: included header DerivedTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:29:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:36:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:58: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:821:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:17:1: error: included header FastJetUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:22:1: error: included header TrackSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:23:1: error: included header TrackSelectionDefaults.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:24:1: error: included header EventSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:25:1: error: included header TrackSelectionTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:40:103: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:60:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:60:21: error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:63:8: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:66:28: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:74:92: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:76:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:122:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 54 -gt 0 ]]
++ cat /sw/BUILD/09189678f90c0b3c35af5cfc80e39d4ad3741be2/O2Physics-code-check/warnings.txt
PWGJE/Core/JetDerivedDataUtilities.h:77:7: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Core/JetDerivedDataUtilities.h:308:7: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Core/JetDerivedDataUtilities.h:508:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetDerivedDataUtilities.h:650:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetDerivedDataUtilities.h:674:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetDerivedDataUtilities.h:743:10: warning: variable 'end' is not initialized [cppcoreguidelines-init-variables]
PWGJE/Core/JetFindingUtilities.h:44:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Core/JetFindingUtilities.h:269:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetFindingUtilities.h:270:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:351:82: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetFindingUtilities.h:353:7: warning: do not use 'else' after 'continue' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:412:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/JetFinders/jetFinderHFHFBar.h:48:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/JetFinders/jetFinderHFHFBar.h:51:8: warning: constructor does not initialize these fields: pdgDatabase [cppcoreguidelines-pro-type-member-init]
PWGJE/JetFinders/jetFinderHFHFBar.h:188:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/JetFinders/jetFinderHFHFBar.h:189:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/JetFinders/jetFinderHF.h:48:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 657a059 at 2026-10-07 16:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 23 errors and 54 warnings.'
Found 23 errors and 54 warnings.
++ [[ 23 -gt 0 ]]
++ cat /sw/BUILD/b5243853372f60744a32cb3e8ddad13a273fe160/O2Physics-code-check/errors.txt
Common/DataModel/Multiplicity.h:220:16: error: no header providing "o2::aod::is_origin_hash" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:16:1: error: included header JetDQUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:18:1: error: included header JetV0Utilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:26:1: error: included header ReducedInfoTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:27:1: error: included header DerivedTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:29:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:36:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:162:58: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/TableProducer/derivedDataProducerEmbedding.cxx:822:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:17:1: error: included header FastJetUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:21:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:22:1: error: included header TrackSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:23:1: error: included header TrackSelectionDefaults.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:24:1: error: included header EventSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:25:1: error: included header TrackSelectionTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:40:103: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:60:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:60:21: error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:63:8: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:66:28: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:74:92: error: no header providing "operator""_h" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:76:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/embeddingQA.cxx:122:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 54 -gt 0 ]]
++ cat /sw/BUILD/b5243853372f60744a32cb3e8ddad13a273fe160/O2Physics-code-check/warnings.txt
PWGJE/Core/JetDerivedDataUtilities.h:77:7: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Core/JetDerivedDataUtilities.h:308:7: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Core/JetDerivedDataUtilities.h:508:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetDerivedDataUtilities.h:650:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetDerivedDataUtilities.h:674:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetDerivedDataUtilities.h:743:10: warning: variable 'end' is not initialized [cppcoreguidelines-init-variables]
PWGJE/Core/JetFindingUtilities.h:44:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Core/JetFindingUtilities.h:269:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetFindingUtilities.h:270:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:351:82: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetFindingUtilities.h:353:7: warning: do not use 'else' after 'continue' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:412:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/JetFinders/jetFinderHFHFBar.h:48:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/JetFinders/jetFinderHFHFBar.h:51:8: warning: constructor does not initialize these fields: pdgDatabase [cppcoreguidelines-pro-type-member-init]
PWGJE/JetFinders/jetFinderHFHFBar.h:188:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/JetFinders/jetFinderHFHFBar.h:189:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/JetFinders/jetFinderHF.h:48:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

@nzardosh Please fix the errors before merging to avoid merging regressions.

@nzardosh
nzardosh disabled auto-merge October 7, 2026 16:33
@nzardosh
nzardosh enabled auto-merge (squash) October 7, 2026 16:33
alibuild
alibuild approved these changes Oct 7, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @nzardosh.

@nzardosh

nzardosh commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

will fix in a separate pr :)

@nzardosh
nzardosh merged commit aba4a6d into AliceO2Group:master Oct 7, 2026
14 of 16 checks passed
@ktf

ktf commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Commenting on one of the specific errors, I might have more comments on the others.

@vkucera I think the include checker should probably remain as as a warning, not as an error. It's difficult to enforce, and sometimes it is not producing particularly ergonomic results. For example:

Common/DataModel/Multiplicity.h:220:16: error: no header providing "o2::aod::is_origin_hash" is directly included [misc-include-cleaner,-warnings-as-errors]

should probably be fixed at the level of the framework, not at the level of the user code.

Moreover, clearly people see it more as a nuisance and the cleanup is not worth the discussion. We need to find a better strategy. How about simply having automatic PRs, like we do for the clang-format? Then people decide to merge them or not at their liking.

@vkucera

vkucera commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Hi @ktf

I think the include checker should probably remain as as a warning, not as an error.

Not a good idea. Correct includes are a necessary prerequisite to guarantee compilation of each file without which Clang-Tidy cannot perform a proper code analysis. Plus the unnecessary includes hurt the recompilation time.

It's difficult to enforce

Why? It takes a single command to fix almost all of the cases if we keep it green in the upstream.

Common/DataModel/Multiplicity.h:220:16: error: no header providing "o2::aod::is_origin_hash" is directly included [misc-include-cleaner,-warnings-as-errors]

should probably be fixed at the level of the framework, not at the level of the user code.

OK, let's fix the framework then.

Moreover, clearly people see it more as a nuisance and the cleanup is not worth the discussion.

This I did not quite understand.

How about simply having automatic PRs, like we do for the clang-format?

I wish it was possible but from my experience it is not always the case. I can elaborate in details.

Then people decide to merge them or not at their liking.

This cannot be left to people's liking if they want reliable and meaningful CI.

@ktf

ktf commented Oct 7, 2026

Copy link
Copy Markdown
Member

Not a good idea. Correct includes are a necessary prerequisite to guarantee compilation of each file without which Clang-Tidy cannot perform a proper code analysis. Plus the unnecessary includes hurt the recompilation time.

How about we do it automatically before running clang-tidy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@dsekihat dsekihat dsekihat approved these changes
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@jaimenorman jaimenorman Awaiting requested review from jaimenorman jaimenorman is a code owner
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

Assignees

No one assigned

Labels

common datamodel pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nzardosh @alibuild @vkucera @ktf @dsekihat