Skip to content

[PWGDQ] Add GJ axis definition and fill histograms - #18271

Open
dmallick2 wants to merge 4 commits into
AliceO2Group:masterfrom
dmallick2:master
Open

dmallick2 wants to merge 4 commits into
AliceO2Group:masterfrom
dmallick2:master

Conversation

@dmallick2

Copy link
Copy Markdown
Collaborator

--Add Gottified-Jackson frame axis
-- Add histograms for data and MC

@github-actions github-actions Bot added the pwgdq label Oct 13, 2026
@github-actions github-actions Bot changed the title Add GJ axis definition and fill histograms [PWGDQ] Add GJ axis definition and fill histograms Oct 13, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1214 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ae3b9d6 at 2026-10-13 17:27:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 34 warnings.'
Found 1 errors and 34 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/e7a4993bd10169b009d944dc5cc083b150921858/O2Physics-code-check/errors.txt
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3478:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
++ [[ 34 -gt 0 ]]
++ cat /sw/BUILD/e7a4993bd10169b009d944dc5cc083b150921858/O2Physics-code-check/warnings.txt
PWGDQ/Core/HistogramsLibrary.cxx:1309:137: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/HistogramsLibrary.cxx:1316:141: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/HistogramsLibrary.cxx:1323:141: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/HistogramsLibrary.cxx:1330:137: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/VarManager.cxx:52:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:53:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:55:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:67:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:93:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:147:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:309:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:416:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:483:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:2982:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:2992:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:2993:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1250:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1251:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1636:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1667:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1671:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:4735:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5465:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5468:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5469:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3218:8: warning: constructor does not initialize these fields: fCurrentRun, fTrackCutBitMap1, fTrackCutBitMap2, fCCDB, fValuesQuadruplet, fHistMan [cppcoreguidelines-pro-type-member-init]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3295:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3315:34: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3315:63: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3438:7: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3475:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3507:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3599:26: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d0e1da4 at 2026-10-13 21:15:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 36 warnings.'
Found 1 errors and 36 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/798e1d738dfc141cb8e0ecc6cbeb531402c36357/O2Physics-code-check/errors.txt
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3478:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
++ [[ 36 -gt 0 ]]
++ cat /sw/BUILD/798e1d738dfc141cb8e0ecc6cbeb531402c36357/O2Physics-code-check/warnings.txt
PWGDQ/Core/HistogramsLibrary.cxx:1309:137: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/HistogramsLibrary.cxx:1316:141: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/HistogramsLibrary.cxx:1323:141: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/HistogramsLibrary.cxx:1330:137: warning: use nullptr [modernize-use-nullptr]
PWGDQ/Core/VarManager.cxx:52:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:53:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:55:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:67:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:93:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:147:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:309:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:416:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:483:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:2982:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:2992:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:2993:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1250:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1251:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1636:15: warning: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1667:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1671:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:4735:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5465:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5468:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5469:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3218:8: warning: constructor does not initialize these fields: fCCDB [cppcoreguidelines-pro-type-member-init]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3295:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3315:34: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3315:63: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3438:7: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3475:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3507:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3598:26: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants