Repository navigation
[PWGHF] Add PCH for PWGHF - #18308
Merged
Merged
Conversation
ktf
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
October 15, 2026 10:36
|
O2 linter results: ❌ 0 errors, |
vkucera
reviewed
Oct 15, 2026
Collaborator
There was a problem hiding this comment.
The PCH compilation is missing.
Member
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
That's for hfCandidatesPCH.cxx.
I don't see the rule for d2hReducedPCH.cxx in PWGHF/D2H/Core/CMakeLists.txt.
Member
Author
There was a problem hiding this comment.
I must have made a mistake in the split. I will add it back.
Member
Author
|
You mean the empty cxx? You only need a placeholder, no? The files to precompile come from the CMake rule. |
Collaborator
Where is the CMake rule? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.