Repository navigation
fix(codex): recognize wrapped question cards - #201
Merged
Merged
Conversation
alvinycheung
marked this pull request as ready for review
September 10, 2026 08:51
Owner
|
Thanks @alvinycheung, this is careful work, and it lands. I keep your commit as it is. Your joins only happen between the fixed header and footer of the card, and the guard still compares the whole card before it sends a digit. So a wrapped list outside a card cannot be taken for a question. The tests are layout variants of the fruit capture. A capture of a real wrapped card is still the missing piece, and I will check one live before the release. You get credit in the changelog, and GitHub closes the PR when main goes out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex questions lose their buttons in Collie when the question or description wraps, or
esc to interruptgets its own row. I saw this with Codex 0.153.4 and Collie 1.8.0, with Raw terminal off.This fixes those three shapes in the question parser. It joins wrapped question and description text and keeps the original rows in the tap signature. The digit keys stay the same. Notes mode, incomplete options, and output below the footer still fall back to the terminal.
The tests modify the existing public fruit capture. All four wrapping cases fail against the old parser and pass with this change. These are synthetic variants of that capture, not new live captures.
Checks:
bridge/journal/pi.test.ts. It compares/var/...with/private/var/...on macOS.Leaving this as a draft for maintainer live-verification on a wrapped card. I did not send keys to the work session used for the read-only diagnosis. No version or CHANGELOG files changed.