Skip to content

Apply filter when scan SQL results#2028

Open
dentiny wants to merge 1 commit into
Altinity:0.27.2from
dentiny:hjiang/apply-filter-before-push
Open

Apply filter when scan SQL results#2028
dentiny wants to merge 1 commit into
Altinity:0.27.2from
dentiny:hjiang/apply-filter-before-push

Conversation

@dentiny

@dentiny dentiny commented Jul 3, 2026

Copy link
Copy Markdown

Hi team, we've found OOM for metrics collector sidecar; reading through the code, it reads to me that

  • Metrics collector for system metrics composes UNION SQL statements to clickhouse and get the data back
  • Users are able to specify which system metrics to exclude, but these metrics are still pushed into in-memory Table, and only get filtered out right before written to prometheus writer

In this PR, to reduce the peak memory consumption, I move the filter logic before pushing into Table.

Signed-off-by: dentinyhao <dentinyhao@gmail.com>
@sunsingerus sunsingerus added the planned for review This feature is planned for review label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

planned for review This feature is planned for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants