convert CamelCase tags to kebab-case#896
Merged
Merged
Conversation
Contributor
|
Maybe consider a followup PR which refactors the dupe code into fastcore so we don't end up with a similar issue next time we make a change like this? (This is my bad in the first place for reimplementing this!) |
Contributor
Author
|
Thanks @jph00, I refactored the duplicated code in fastcore so the implementation can be shared. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle CamelCase tag imports from
fasthtml.componentssimilarly to fromfastcore.xml