Conversation
Afloat16
marked this pull request as ready for review
September 29, 2026 08:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
No matching submission found in the duplicate check. The separate final-knot issue in #1433 is outside this change.
What does this implement/fix?
Reject duplicate x coordinates before constructing zero-width cubic-spline intervals, using the existing ValueError validation path. Update the docstring to require strictly increasing knots.
Regression tests cover repeated knots, duplicate consecutive 2D waypoints, decreasing knots, and valid spline values and derivatives against SciPy.
Additional information
Validation: 15 regression tests passed with Python 3.13.15, NumPy 2.5.3 and SciPy 1.18.1. Ruff E/F checks (excluding E501) on the new test and git diff --check passed. The full project suite and upstream CI have not been run here.
CheckList