Pre-release 0.2.11b1: decouple extension metadata from wheel==0.30.0#549
Open
aryasadeghi1 wants to merge 4 commits into
Open
Pre-release 0.2.11b1: decouple extension metadata from wheel==0.30.0#549aryasadeghi1 wants to merge 4 commits into
aryasadeghi1 wants to merge 4 commits into
Conversation
… generation and extension modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the legacy
wheel==0.30.0metadata.jsonread path withpkginfo-based METADATA parsing, so the Azure CLI ecosystem can move off thewheel==0.30.0andsetuptools==70.0.0pins.Impacts
setuptoolspast the==70.0.0pin, which is required to pick up the fix for CVE-2025-47273 (path traversal, fixed in setuptools 78.1.1). Context: {Package} Upgrade setuptools and wheel to the latest version. azure-cli-extensions#7740.wheelrelease.Approach
Picks up from #521 (thanks @wangzelin007), but per @jiasli's review comment the implementation now uses
pkginfo.Wheelinstead of vendoring wheel 0.30.0 internals.azdev/operations/extensions/metadata.pywithpkginfo_to_dictandmerge_to_index_metadata.get_ext_metadatainutil.pynow reads METADATA viapkginfoand merges azext-only keys on top, eliminating the dependency on the legacymetadata.jsonartifact (no longer emitted by modernwheel).setup.py: dropswheel==0.30.0andsetuptools==70.0.0; addspkginfoandsetuptools>=78.1.1,<80(upper bound preservessetup.py developfor unmigrated extensions).0.2.11b1(pre-release) so we can validate before promoting to0.2.11(release).Tests
azdev/operations/tests/test_metadata.py:pkginfo_to_dict,merge_to_index_metadata,_coerce_run_requires(handling metadata duplication), and the azext-override precedence.azure_cli_ml-1.41.0wheel andDeepDiffs the generated metadata against the historicalindex.jsonblock. Fields that wheel 0.30.0 only ever emitted via its side-channelmetadata.json. Test skips on network failure.Supersedes #521.
Closes #521.