fix(terraform): batch provider schema retrieval - #126
Merged
Jared Holgate (jaredfholgate) merged 1 commit intoSep 4, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jack Tracey (jtracey93)
approved these changes
Sep 4, 2026
Jared Holgate (jaredfholgate)
deleted the
jaredfholgate-provider-schema-batching
branch
September 4, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider_schemarequests into one temporary Terraform configuration and oneterraform init -upgrade/terraform providers schemacycle.Performance
Repeatable local benchmark (fake Terraform runner, no network):
A warmed end-to-end transform fixture using the AVM constraints (
azurerm ~> 4.0,azapi ~> 2.4,random ~> 3.0) measured:The transformed
main.tffiles were byte-identical (matching SHA-256).Persistent cache follow-up
A cross-process schema cache is intentionally not included. AVM uses open constraints, so caching by constraint could return stale schemas and violate
-upgrade. A safe follow-up should initially cache exact versions only, key by normalized source + exact selected version + Terraform version + platform + schema format, and use inter-process locking with atomic publication.Validation
go build github.com/Azure/mapotfgo test -v github.com/Azure/mapotf/...golangci-lint run --timeout=3600sgosec ./...reports the same pre-existing G204 finding oncmd/terraform_cmd_wrapper.go:26asorigin/main