Bump JsRuntimeHost to a6b98eaa (forward std streams) - #1861
Merged
bkaradzic-microsoft merged 1 commit intoSep 2, 2026
Merged
Conversation
Picks up BabylonJS/JsRuntimeHost#233: Forward native standard streams to platform diagnostics. Master was on 0d263627 (setInterval queue fix); main is one commit ahead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d47cbab2-d751-4cf9-984f-4412dd9ec601
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Updating a core runtime dependency commit can have broad cross-platform/runtime effects that should be validated by CI and/or human review before approval.
Pull request overview
Updates BabylonNative’s CMake dependency pin for JsRuntimeHost to pick up upstream changes that forward native standard streams to platform diagnostics.
Changes:
- Bump
JsRuntimeHostFetchContentGIT_TAGfrom0d263627…toa6b98eaa….
File summaries
| File | Description |
|---|---|
| CMakeLists.txt | Updates the pinned JsRuntimeHost commit SHA used by CMake FetchContent. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bghgary
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
JsRuntimeHostfrom0d263627toa6b98eaa(currentmain).What's included
Master already had through JsRuntimeHost#220 (setInterval queue fix). This is the single remaining commit on
main.Test plan