Bump JsRuntimeHost for V8 asynchronous WebAssembly task handling - #1870
Merged
Merged
Conversation
Update to f47991dd5729fac1d6d477e66ed8a843da1d4832, the latest JsRuntimeHost main revision. This includes BabylonJS/JsRuntimeHost#232, which dispatches V8 foreground tasks through AppRuntime so asynchronous WebAssembly compilation promises can settle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 88569c10-a7ff-4373-9a58-afa9c68b8c09
bghgary
approved these changes
Sep 11, 2026
bkaradzic-microsoft
enabled auto-merge (squash)
September 11, 2026 00:13
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The runtime and scheduler changes warrant final human validation.
Pull request overview
Updates the JsRuntimeHost dependency for asynchronous WebAssembly task handling.
Changes:
- Bumps the JsRuntimeHost commit pin.
- Includes upstream PR #232’s task-dispatch and scheduler lifecycle fixes.
- Excludes the open standard-stream logger follow-up.
File summaries
| File | Description |
|---|---|
CMakeLists.txt |
Updates the JsRuntimeHost dependency revision. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the JsRuntimeHost pin from
a6b98eaa1a9887b35adceed21f8c7d44c4f38e43tof47991dd5729fac1d6d477e66ed8a843da1d4832, the latest upstreammain.Includes BabylonJS/JsRuntimeHost#232:
This is a one-line dependency-pin update based on current Babylon Native
master.The standard-stream logger follow-up, BabylonJS/JsRuntimeHost#236, is still open and is not included in this revision.