Fix revenue accuracy, precision, and tenant isolation - #172
Open
RossiAlexis wants to merge 1 commit into
Open
Conversation
… dashboard features - Created a .gitignore file to exclude unnecessary files and directories. - Added a findings document detailing issues and fixes related to the revenue dashboard. - Implemented tenant-aware revenue calculations, ensuring accurate data retrieval based on user permissions. - Updated API endpoints to support tenant-specific property access and revenue summaries. - Enhanced frontend components to dynamically load properties and display revenue data based on selected month and year. - Added unit tests for revenue calculations and tenant isolation to ensure functionality and correctness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the revenue accuracy and privacy issues reported by Sunset Properties and Ocean Rentals.
Changes
Verification:
✅ 7 backend tests passing
✅ Frontend production build passing
✅ Tested with both supplied client accounts
✅ Sunset March prop-001: USD 2250.00 — 4 reservations
✅ Ocean March prop-001: USD 0.00
✅ Repeated refreshes remain tenant-isolated
✅ Timezone-boundary reservation is correctly assigned to March
Detailed Findings
A complete explanation of the investigation, root causes, fixes, and verification is available in finding.MD.
Loom walkthrough
Video: Loom
P.S. Recording myself is a little outside my comfort zone, but I hope the walkthrough clearly communicates my investigation and decisions.