Skip to content

Update compatible VotingPlugin dependencies - #1737

Open
BenCodez wants to merge 1 commit into
masterfrom
vp-work/dependency-consolidation-20261029
Open

BenCodez wants to merge 1 commit into
masterfrom
vp-work/dependency-consolidation-20261029

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Updates Jedis to 8.0.2, SnakeYAML to 2.7 and Maven Surefire to 3.6.0 together. The existing Velocity and NeoForge loader versions remain in place for Java 21 and current platform compatibility.

Validation: 116 focused Redis and configuration tests passed. A clean package passed 2,906 unit tests, one optional diagnostic was skipped, and all five packaged-artifact checks passed. The 10,990,162-byte JAR passed ZIP integrity; it exceeds the advisory 10 MiB target. All 856 packaged Jedis classes match the selected 8.0.2 JAR; SnakeYAML and FoliaLib relocation and test-library exclusion were checked. A fresh independent source review found no issues.

This supersedes the dependency changes in #1728, #1729 and #1731. It does not include #1730 or #1732: the proposed loader lacks classes used by the current NeoForge source, and the proposed Velocity API requires a newer Java class-file version than the Java 21 build. Native platform acceptance and normal published dependency adoption remain separate.

Summary by CodeRabbit

  • Chores
    • Updated supporting libraries and test tooling to newer versions.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bf9433dd-ca1e-4937-9d96-ae7222ab799c
Commits

Reviewing files that changed from the base of the PR and between 2a1e4e1 and 2e8cb4b.

Files selected for processing: 1
  • VotingPlugin/pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Recent review details
Context from checks skipped due to timeout: 3
  • GitHub Check: build
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (java-kotlin)
Additional context used
Learnings: 1
Common learnings
Learnt from: CR
Repo: BenCodez/VotingPlugin PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-20T09:11:25.910Z
Learning: Source excerpt:
# Maintainer and AI-agent guide

## Build and verification

Keep the downloadable VotingPlugin JAR as small as practical. The 10 MiB size target is advisory:
report a prominent package/build warning when exceeded, never fail a build solely for artifact size.
Keep required-resource, linkage, and packaging-safety checks enforced. Inspect the shaded
artifact when dependencies change, avoid duplicate embedded packages, and update
the package-phase size and runtime checks when a necessary dependency increases
the artifact budget.
Additional comments: 2
VotingPlugin/pom.xml: 2

274-274: LGTM!

Also applies to: 411-411

485-485: 📐 Maintainability & Code Quality

The package-size warning is already non-blocking.

PackagedArtifactTest warns when the artifact exceeds 10 MiB and does not reject the artifact because of its size. No change is required.

Walkthrough

The Maven Surefire plugin version changes from 3.5.4 to 3.6.0. SnakeYAML changes from 2.6 to 2.7. Jedis changes from 8.0.1 to 8.0.2.

Changes: Dependency Version Updates

Layer / File(s) Summary
Update dependency versions
VotingPlugin/pom.xml
The Maven Surefire plugin, SnakeYAML, and Jedis versions are updated.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 2e8cb

The dependency updates have no established compatibility or packaging failure, so the PR is mergeable.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Update compatible VotingPlugin dependencies" matches the main change. The raw summary shows VotingPlugin/pom.xml updating Maven Surefire to 3.6.0, SnakeYAML to 2.7, and Jedis to 8.0.2, whic…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Update compatible VotingPlugin dependencies" matches the main change. The raw summary shows VotingPlugin/pom.xml updating Maven Surefire to 3.6.0, SnakeYAML to 2.7, and Jedis to 8.0.2, which are dependency updates. The title is specific enough for a teammate to understand the primary change. It does not name the three libraries, but it does not need to list every detail. The word "compatible" is slightly vague, but the PR objectives explain that the updated versions were chosen for Java 21 and platform compatibility.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenCodez
BenCodez marked this pull request as ready for review October 29, 2026 06:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T06:12:35.180540Z 2e8cb4b Draft marked ready
🔒 Security Review ✅ Completed 2026-10-29T06:13:56.555829Z 2e8cb4b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant