WebOS runner refactor - #465
Closed
SankarRealm wants to merge 3 commits into
Closed
SankarRealm wants to merge 3 commits into
SankarRealm wants to merge 3 commits into
Conversation
|
Are you new to GitHub? You probably should push those changes to #450 instead of making another PR since that one isn't even merged yet |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the WebOS port to use the upstream SDL2 backend and the refactored Runner architecture instead of maintaining a separate monolithic WebOS SDL2/platform implementation.
Changes
src/backends/sdl2.cbackend for WebOS.src/webos/main.cto the platform entry point.platformLog()implementation insrc/webos/log.c.src/webos/platform.cimplementation.src/webos/stat_compat.c.Testing
Built successfully from a clean CMake configuration using the WebOS SDK SDL2 2.30.12.
Tested on an actual LG webOS TV:
Notes
The WebOS B-button/exit-window behavior is not addressed by this PR. It will be investigated separately.
This PR is focused on moving the WebOS port onto the upstream/refactored Runner architecture and removing the duplicated WebOS-specific SDL2/platform implementation.