Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2123 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 30 30
Lines 9605 9605
Branches 1443 1443
=======================================
Hits 9203 9203
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1637.
Sketch.bezierused to callself._endPoint()before building the curve, so it raised when the sketch had no edges yet. That call has since been removed (the curve is built only from the given points), but the issue is still open and nothing tests the case, so a regression could come back unnoticed.This adds
test_bezier_without_prior_edge, which checks that:segment, assembles into one face;Test only, no library changes.
pytest tests/test_sketch.pypasses locally (37 passed) on current master with cadquery-ocp 8.0.1.1.0, Python 3.13, Windows.I used an AI assistant to help find the issue and draft the test; I checked the math and ran the suite myself.