Repository navigation
Fix four default values in docstrings - #2134
Open
ZainnQureshii wants to merge 1 commit into
Open
ZainnQureshii wants to merge 1 commit into
ZainnQureshii wants to merge 1 commit into
Conversation
Workplane.parametricSurface defaults to tol=1e-2 and maxDeg=6, Face.makeSplineApprox to maxDeg=3, and both Solid.sweep overloads to transitionMode='transformed', but the docstrings said 1e-3, 3, 6 and 'right'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2134 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 30 30
Lines 9605 9605
Branches 1443 1443
=======================================
Hits 9203 9203
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four docstrings gave default values that differ from their signatures:
Workplane.parametricSurface:tol1e-3 -> 1e-2 andmaxDeg3 -> 6 (cadquery/cq.py:1991,:1993)Face.makeSplineApprox:maxDeg6 -> 3 (cadquery/occ_impl/shapes.py:3752)Solid.sweep:transitionMode'right' -> 'transformed' (both overloads,shapes.py:4679and:4736)Docstrings only, no behaviour change. Each value was compared to its signature, and a script that checks every
(default: ...)in the changed docstrings against the signature reports no mismatch after the change.Prepared with AI assistance (Claude Code) and reviewed with GitHub Copilot.
🤖 Generated with Claude Code