Implement gauntlet options for booster draft#10989
Open
ItsameGui wants to merge 3 commits into
Open
Conversation
- Add options dialog to set gauntlet rounds and match length - Persist selected values between sessions - Include initial support for multiple rounds and help dialogs Closes Card-Forge#10568 Co-authored-by: Pedro Andrade <pedro.d.andrade@tecnico.ulisboa.pt>
Comment on lines
+3567
to
+3570
| lblExportLogsDescription=Export forge.log files an | ||
| View PedroCalhau's full-sized avatar | ||
| Pedro Andrade PedroCalhau | ||
| d network debug logs to Downloads folder as a zip |
Contributor
There was a problem hiding this comment.
Seems like an editing error has slipped in here.
Comment on lines
-3577
to
-3600
| lblusepricelist=Use the (currently experimental) price generation based on a set cardlist. | ||
| lblBracket=Bracket | ||
| ttCommanderBracket=Suggested minimum Commander bracket | ||
| lblBracketView=Bracket View | ||
| lblCommanderBracketMinimum=Minimum Commander Bracket: {0} | ||
| lblCommanderBracketSelectDeck=Select a Commander deck to see its bracket explanation. | ||
| lblCommanderBracketGameChangers=Game Changers | ||
| lblCommanderBracketMassLandDenial=Mass Land Denial | ||
| lblCommanderBracketExtraTurns=Extra Turns | ||
| lblCommanderBracketChainedExtraTurns=Chained Extra Turns | ||
| lblCommanderBracketTwoCardCombos=2-card Combos | ||
| lblCommanderBracketLateGame=Late Game | ||
| lblCommanderBracketEarlyGame=Early Game | ||
| lblCommanderBracketReasonGameChangersFour=4 or more Game Changers make the deck at least Bracket 4. | ||
| lblCommanderBracketReasonGameChangersOne=1 to 3 Game Changers make the deck at least Bracket 3. | ||
| lblCommanderBracketReasonMassLandDenial=Mass Land Denial makes the deck at least Bracket 4. | ||
| lblCommanderBracketReasonChainedExtraTurn=Chained Extra Turn cards make the deck at least Bracket 4. | ||
| lblCommanderBracketReasonExtraTurnsFour=4 or more Extra Turn cards make the deck at least Bracket 4. | ||
| lblCommanderBracketReasonExtraTurnsThree=3 or more Extra Turn cards make the deck at least Bracket 3. | ||
| lblCommanderBracketReasonExtraTurnsTwo=2 Extra Turn cards make the deck at least Bracket 2. | ||
| lblCommanderBracketReasonExtraTurnsFew=Fewer than 2 Extra Turn cards do not raise the bracket. | ||
| lblCommanderBracketReasonLateGameCombo=Late Game 2-card combos make the deck at least Bracket 3. | ||
| lblCommanderBracketReasonEarlyGameCombo=Early Game 2-card combos make the deck at least Bracket 4. | ||
| lblAutoSellVariantsCommander=Auto-sell variants of owned cards in Commander |
| lblPutCardInWhichPlayerZone=Put card in {0} for which player? | ||
| lblPutCardInWhichPlayerBattlefield=Put card on the battlefield for which player? | ||
| lblPutCardInWhichPlayerPlayOrStack=Put card on the stack / in play for which player? | ||
| lblPutTokenInWhichPlayerBattlefield=Put token on the battlefield for which player? |
Comment on lines
+11
to
+13
| /** | ||
| * Unit tests for CSubmenuDraft private parsing logic. | ||
| */ |
Contributor
There was a problem hiding this comment.
Seems pretty unlikely this needs a unit test - AI coding agents have a tendency to add these unnecessarily to try and prove their wiring works, we warn against including these here.
Author
|
I've made some changes taking into account what you mentioned, would it be possible to review the code again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10568
Co-authored by @PedroCalhau pedro.d.andrade@tecnico.ulisboa.pt