Skip to content

Reject trailing-newline processor manifest tokens - #2954

Merged
Chris0Jeky merged 6 commits into
mainfrom
issue-2258/manifest-absolute-anchors
Sep 10, 2026
Merged

Reject trailing-newline processor manifest tokens#2954
Chris0Jeky merged 6 commits into
mainfrom
issue-2258/manifest-absolute-anchors

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • align the .NET processor manifest validator with the published schema by using absolute regex anchors
  • reject processor IDs and currencies that contain a terminal line feed
  • add deterministic regressions for both fields

Scope

This is the bounded CF04-0 validator correction only. It does not add a processor registry, processor host, schema changes, or documentation changes.

Verification

  • dotnet test backend/tests/Taskdeck.Application.Tests/Taskdeck.Application.Tests.csproj -c Release -m:1 --filter FullyQualifiedName~ProcessorManifestValidatorTests - 39 passed
  • dotnet test backend/Taskdeck.sln -c Release -m:1 - 9,386 passed, 5 skipped, 0 failed
  • git diff --check origin/main...HEAD - passed
  • fresh-context review and current-base interaction review - no CRITICAL/HIGH findings

Docs

No docs changed. This correction makes the runtime validator match the already-published schema boundary and does not change the roadmap or shipped feature breadth.

Refs #2258

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T22:15:53.542039Z 4196972 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Round 1 independent review at head 808e37010748e9d714e6abd89d67d054ebe51447 against base be0e1349f21fda89970b93321de0309124ee83f2: no CRITICAL/HIGH correctness, security, data-loss, or scope findings.

The \A...\z validators preserve canonical IDs and currencies while rejecting terminal LF, matching the published schema boundary. Focused validator tests pass 39/39; Application tests pass 4,312/4,312; the same backend tree completed the required full solution run with 9,386 passed, 5 skipped, 0 failed. git diff --check passes. Hosted exact-head CI remains pending.

Disposition: fix-now 0, tracked 0, declined/informational 0.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Current-base interaction extension at head be161e18d73b353bd79df719ab5320c4de8369e6 against base fad49351fc6b307c0f64e0369a8f6b3c8d8aa8cd: no CRITICAL/HIGH finding.

The intervening base delta is limited to Capture polling/API and frontend Inbox surfaces. It does not touch manifest validation, processor contracts, project references, or any call path into ProcessorManifestValidator. The refreshed focused validator suite passes 39/39; the full Application project passes 4,315/4,315; a current-base solution build passes with 0 errors; git diff --check passes. Exact-head hosted CI is pending.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Current-base interaction extension at head 09cc23405f95f624a5ece9486c26e770bc249b67 against base 7695211a0d31590c19845fd0e4cd559be521384e: no CRITICAL/HIGH finding.

The base adds Card work-item-type behavior but no processor-manifest symbols, processing-capability contract, project-reference change, or processor persistence field. The focused validator suite passes 39/39; full Application passes 4,318/4,318; migration bootstrap passes 24/24; the solution builds with 0 errors; git diff --check passes. Exact-head hosted CI is pending.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Current-base interaction extension at head 41969726ae9ecae13bddb2b7077129b415751a93 against base 93ca1cd21a34503c1e773b7447c79b034e99b90e: no CRITICAL/HIGH finding.

The base delta only excludes archived cards in WorkspaceObservationReader and adds API tests. It has no processor-manifest path. The Application tree is byte-identical across the merge, the focused validator suite passes 39/39, and git diff --check passes. Exact-head hosted CI is pending.

@Chris0Jeky
Chris0Jeky merged commit 8b4205f into main Sep 10, 2026
36 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-2258/manifest-absolute-anchors branch September 10, 2026 22:49
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant