Skip to content

refactor(inbox): isolate Paper Triage policies - #2962

Open
Chris0Jeky wants to merge 2 commits into
mainfrom
codex/refactor-paper-triage-policy
Open

refactor(inbox): isolate Paper Triage policies#2962
Chris0Jeky wants to merge 2 commits into
mainfrom
codex/refactor-paper-triage-policy

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • Extract Paper Triage's pure capability, status, board-write, and correction-label policies into a focused utility.
  • Keep the stateful view responsible for reactive editor, picker, notice, and action orchestration.
  • Add direct unit coverage for the policy boundary while preserving the existing view behavior.

Scope

Behavior-preserving structural refactor only. No rendered markup, server contract, status vocabulary, or user-facing behavior is intentionally changed.

Checks

  • npm.cmd ci --ignore-scripts — passed; lockfile unchanged; npm reported the repository's existing 1 moderate audit finding.
  • npx vitest --run --maxWorkers=2 src/tests/utils/paperTriagePolicy.spec.ts src/tests/views/paper/inbox/PaperTriageTable.spec.ts — 98/98 passed on the exact merged head.
  • npx vitest --run --maxWorkers=2 — 6,499 passed, 3 skipped across 421 files before merging the unrelated card-work-item base update.
  • npm.cmd run typecheck — passed on the exact merged head.
  • npm.cmd run build — passed, including Vite/PWA generation, on the exact merged head.
  • npm.cmd run lint — passed with 9 existing warnings and 0 errors.

Review notes

The branch includes a conflict-free merge of current origin/main (7695211a0) so the proposed diff is against the latest main line. Please review the utility boundary and confirm the extracted policies preserve the existing server-authority and D-13 rules.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T21:44:14.713563Z 06dc4d1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

1 participant