Repository navigation
Fix. Patch. utf8_decode() polyfill turned non-ASCII characters into NUL bytes - #55
Merged
Merged
Conversation
Member
|
Merged into dev branch. Also, we plan to fix the same cases in other repos. Thank you very much. |
Member
|
The next stable release will include this pull request. The estimated release timeline is 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
utf8_decode()polyfill inlib/cleantalk-php-patch.phpcombines the bits of multi-byte characters with&instead of|, so every non-ASCII character becomes 0 (a NUL byte). For example,cafébecomescaf\0instead ofcaf\xE9.This changes the six
&operators between the shifted parts to|. The fixed polyfill now returns byte-for-byte the same output as the nativeutf8_decode()for ASCII, Latin-1 (café,Ünïcödé), characters outside Latin-1 (€,日本, which become?) and 4-byte emoji.