bookmark recipe only when not bookmarking ingredient - #249
Open
ZZZank wants to merge 1 commit into
Open
Conversation
Contributor
It still looks a bit odd. Why was a new group added instead of putting it in the previous one?
|
Contributor
Author
This is existed behaviour, and based my research and some failed attempts, fixes for this and bookmarked recipes being in new group will probably worth a new PR, or two |
Contributor
|
Generally speaking, I think this should match players' old habits? A config option could be added to determine this bookmarking behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behaviour is, when bookmarking an ingredient, if the mouse is also on a recipe (the ingredient should then belongs to the recipe), the recipe, instead of ingredient, will get bookmarked, this means you can basically never bookmark an individual ingredient in a recipe:
2026-09-08.200158.mp4
This PR fixed this by always bookmark ingredient when there's one, and bookmark recipe only when no ingredient is found:
hei-bookmark-recipe-after.mp4