Exercise PostgreSQL ClickPipe creation through the live CLI - #541
Conversation
|
Carry-over review from PR #503 (old PR for #447). Design-wise this PR is better than #503 (self-describing rename, extracted
|
032c3b3 to
70fa877
Compare
70fa877 to
3af64db
Compare
54910a5 to
f00c6fd
Compare
f00c6fd to
41b403e
Compare
41b403e to
420426a
Compare
77e258e to
ce1179f
Compare
ce1179f to
01059f7
Compare
01059f7 to
cabfa1b
Compare
cabfa1b to
b532b38
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e43ad29. Configure here.
| .into()); | ||
| } | ||
| Ok(path) | ||
| } |
There was a problem hiding this comment.
Relative CLI path fails locally
Low Severity
clickhousectl_binary checks CLICKHOUSE_CLOUD_TEST_CLICKHOUSECTL_BIN with is_file() against the test process working directory. Cargo sets that to the clickhouse-cloud-api package root, not the workspace. The documented target/debug/clickhousectl path is workspace-relative, so the live test rejects a valid binary. CI is unaffected because the workflow uses an absolute path.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e43ad29. Configure here.


Summary
clickhousectlbinary--ca-certificate, then write the fetched CA bundle and verify successful creation, Running state, snapshot rows, and ongoing CDCCLICKHOUSE_CLOUD_TEST_CLICKHOUSECTL_BINrequirementFINALTests
cargo test -p clickhouse-cloud-api --test clickpipe_postgres_cli_cdc_testcargo test -p clickhousectl --bin clickhousectl postgres_cargo test -p clickhousectl --test cli_request_shape_test postgres_python3 -m unittest discover -s scripts/tests -p "test_*.py"cargo fmt --all --checkcargo clippy -p clickhouse-cloud-api -p clickhousectl --all-targets -- -D warningsclickpipesscope on300a284d10856697058afdf041bd3ef5840d81d7The credentialed live run passed. The managed Postgres fixture uses a private CA, so success without an uploaded CA remains a residual gap until CI provides a publicly trusted PostgreSQL source.
Closes #447