Skip to content

Keep local install workflow triggers aligned - #546

Open
sdairs wants to merge 3 commits into
stack/456-atomic-local-installsfrom
stack/461-install-workflow-paths
Open

Keep local install workflow triggers aligned#546
sdairs wants to merge 3 commits into
stack/456-atomic-local-installsfrom
stack/461-install-workflow-paths

Conversation

@sdairs

@sdairs sdairs commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expand the live install workflow path filter to the current ClickHouse installer dependency surface
  • keep unrelated local Docker/Postgres sources and tests outside the expensive matrix
  • add a fail-closed classifier and static workflow mapping coverage in install and broad CLI CI

Tests

@sdairs

sdairs commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Carry-over review from PR #512 (old PR for #461). This PR is preferred over #512 and is approved on its own merits (meets all four acceptance criteria; CI fully green including the install matrix). No sdairs review comments existed on #512. For completeness, reasons this PR wins over #512, plus minor items:

Why preferred over #512:

Minor items (optional follow-ups):

  1. The argparse CLI (main()/classify_paths() in scripts/classify-install-integration.py:~114-128) is never invoked by any workflow in this diff — currently dead code. It matches the classify-cloud-integration.py convention, so keep it if it will be wired up, otherwise note it is reserved for future use.
  2. The inventory test only globs *.rs; non-.rs files under tests/ (future snapshots) aren't covered. Keep local install workflow triggers aligned #512 inventoried all files. Consider broadening if snapshot tests land.
  3. Unlike Keep local install workflow triggers aligned #512, no test pins the exact install/no-install mapping sets — a file could be moved between INSTALL_EXACT_PATHS and NON_INSTALL_EXACT_PATHS and only the workflow-equality test would catch it (it would, but less review-visible). Consider pinning the sets.

@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from 8daf9d7 to aa47a28 Compare August 26, 2026 18:58
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from aa47a28 to 40604da Compare August 26, 2026 19:01
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from 40604da to 4db5794 Compare August 26, 2026 19:03
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from 4db5794 to 271bc34 Compare August 26, 2026 19:07
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch 2 times, most recently from 8a0ee70 to ff79cde Compare August 26, 2026 19:12
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from ff79cde to 1694b80 Compare August 26, 2026 19:20
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch 2 times, most recently from 4bdcd8d to 48e2a2a Compare August 26, 2026 19:28
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch 2 times, most recently from cfbcea2 to 2d2ee20 Compare August 26, 2026 19:34
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from 2d2ee20 to e1cafe2 Compare August 26, 2026 19:36
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from e1cafe2 to 0b71cb0 Compare August 26, 2026 20:10
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from 0b71cb0 to 171a588 Compare August 26, 2026 20:30
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch 2 times, most recently from c2e3c2e to 7602ed6 Compare August 26, 2026 20:38
@sdairs
sdairs force-pushed the stack/461-install-workflow-paths branch from 7602ed6 to feb77f4 Compare August 26, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant