Make omitted local server selection deliberate - #557
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dbeb1a8. Configure here.
|
Carry-over review from PR #514 (old PR for #473). This PR is preferred as the base: better dispatch modeling (
CI note: |
dbeb1a8 to
a02b2c5
Compare
a694feb to
43dfee6
Compare
43dfee6 to
4e6d763
Compare
4e6d763 to
3efce63
Compare
3efce63 to
5335622
Compare
5335622 to
2fe9959
Compare
2fe9959 to
47b4710
Compare
4df2ea3 to
bb031c5
Compare
5e68ca9 to
f4287a1
Compare
0c54a1a to
531052b
Compare
b429415 to
937b759
Compare
937b759 to
d94e6a7
Compare
6bd73d0 to
7022e4b
Compare
7022e4b to
5aa888b
Compare
5aa888b to
256e7a3
Compare
256e7a3 to
46732c2
Compare
46732c2 to
7c8dbbc
Compare
372ddfd to
43ef385
Compare
070991f to
b47e5a7
Compare
b47e5a7 to
343f02a
Compare

Summary
defaultor a sole ClickHouse server deliberately for an omitted project-scopedserver stopname, while keeping omittedstop --globalpinned to literaldefaultserver removeconservative and exclude Postgres metadata and data remnants from ClickHouse selection--namedispatch hidden from help and preserve positional dispatchselectionfor both implicit and explicit ClickHouse stop/remove outcomes; Postgres output omits the optional fieldserver_selection_requiredstructured error codeTests
cargo test -p clickhousectl --test local_server_selection_testcargo test -p clickhousectl --test local_postgres_readiness_test -- --test-threads=1cargo test -p clickhousectl --test local_server_name_compatibility_testcargo test -p clickhousectl --test local_server_stopped_testcargo test -p clickhousectl --test local_structured_errors_test -- --test-threads=1cargo test -p clickhousectl -- --test-threads=1cargo fmt --all --checkcargo check -p clickhousectl --all-targetscargo clippy -p clickhousectl --all-targets -- -D warningsCloses #473