Drop Vec elements on scope exit and infer Option::None from call arguments (v0.1.19) - #18
Merged
Merged
Conversation
…ments. Owned Vec and Box values leaked nested heap on drop, and unannotated Option::None could not use a function parameter as expected type.
Option wrapping a cyclic Vec was getting an unused static helper, which Linux gcc -Werror rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec<T>scope-exit drop now drops remaining elements whenTneeds destruction, thenion_vec_free. This impacts anyVec<String>,Vec<Vec<U>>, orVecof structs/enums with owned fields (previously the backing array was freed and elements leaked).Vec::getof suchThollows the slot (already specified as move-out).Vec::setdrops the previous element.Vec<int>and other Copy elements are unchanged.Box<T>dropsTbeforeion_box_freewhenTneeds destruction;Box::unwrapstill does not dropT.Option::None/ other no-payload generic variants inferTfrom a call argument's parameter type (any position), matching return and struct-field positions. Unannotatedlet empty = Option::Nonestill requires an annotation. This impacts passingOption::NoneorResult::Err(...)directly into a function.Test plan
cargo fmt --checkcargo testcargo clippy -- -D warningstests/test_runner.sh(Linux CI)ion-buildprojects compiletake(Option::None)infersT; unannotatedlet empty = Option::Nonestill errors