Infer Option::None from send and Box::new expected types (v0.1.20) - #19
Merged
Conversation
Builtin value parameters were not checking-mode sites, so send(&tx, Option::None) still required a typed temporary after user-function calls already inferred T.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send(&tx, Option::None)infersTfromSender<T>, andBox::new(Option::None)infers from an expectedBox<Option<...>>. This impacts passing unannotated no-payload generic variants intosendorBox::new(user-function call arguments already inferred in 0.1.19). Unannotatedlet empty = Option::Nonestill requires an annotation.Test plan
cargo fmt --checkcargo testcargo clippy -- -D warningstests/test_runner.sh(Linux CI)ion-buildprojects compilesend(&tx, Option::None)andBox::new(Option::None)compile; unannotatedlet empty = Option::Nonestill errors