Emit named C array typedefs and nested generic enums - #21
Merged
Conversation
Nested arrays and Box/Vec of arrays need identifier type names, and enum payloads such as Hold::H(Option::None) must collect and emit Option_int before the embedding type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arr_int_2) so nested arrays,Box<[T; N]>, andVec<[T; N]>emit valid C. Array return ABI stays pointer decay.Option_intbefore embedding types such asHold. Forward-declare user structs/enums soOption_ref_Opis valid C.Test plan
cargo fmt --checkcargo clippy -- -D warningscargo testtests/test_runner.sh(345 passed)ion-buildeveryexamples/*/ion.toml; data_lib output matches README