Skip to content

Space#60

Merged
PenguinBoi12 merged 4 commits into
mainfrom
feature/space
Jun 17, 2026
Merged

Space#60
PenguinBoi12 merged 4 commits into
mainfrom
feature/space

Conversation

@PenguinBoi12

@PenguinBoi12 PenguinBoi12 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This PR adds support for spaces through a new Space Object derived from Room. Additionally, it changes the behaviour of bot.get_room to support proper instantiation of Room or Space depending on whether a room is a space or not.

For now, the Space object does nothing more than Room and will mainly serve has a new room type , additional features for the class will be added in other PRs.

@PenguinBoi12 PenguinBoi12 self-assigned this Jun 16, 2026
@PenguinBoi12 PenguinBoi12 requested a review from chrisdedman June 17, 2026 01:01
@PenguinBoi12 PenguinBoi12 marked this pull request as ready for review June 17, 2026 01:01
Comment thread matrix/space.py


class Space(Room):
pass

@PenguinBoi12 PenguinBoi12 Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is normal, additional features will be added in other PR

@chrisdedman chrisdedman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PenguinBoi12 PenguinBoi12 merged commit f141d33 into main Jun 17, 2026
4 checks passed
@PenguinBoi12 PenguinBoi12 deleted the feature/space branch June 17, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants