Sheffield | 26-Jan-ITP | Karim M'hamdi | Sprint 3 | Quote generator - #1166
Closed
KKtech06 wants to merge 2 commits into
Closed
Sheffield | 26-Jan-ITP | Karim M'hamdi | Sprint 3 | Quote generator#1166KKtech06 wants to merge 2 commits into
KKtech06 wants to merge 2 commits into
Conversation
KKtech06
added
the
Needs Review
cjyuan
reviewed
Apr 8, 2026
Comment on lines
+18
to
+20
| newQuoteButton.addEventListener("click", function () { | ||
| showRandomQuote(); | ||
| }); |
Contributor
There was a problem hiding this comment.
When the callback contains only a function call that does not involve any parameter, we can also write:
newQuoteButton.addEventListener("click", showRandomQuote);
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist: I have improved my code and got the qoute generator to function
Questions
N/A